Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info pointer for singleton and refinement types, #2933 #2934

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

vreuter
Copy link
Contributor

@vreuter vreuter commented Dec 14, 2023

No description provided.

@SethTisue
Copy link
Member

We don't normally link from ordinary documentation — especially tutorial documentation like the Scala 3 Book — to the language specification, which is so much more formal and technical. We might link to the spec if no other reference documentation was available, but in this case, reference documentation is available and we already link to it.

(Does the reference documentation link to the relevant section of the spec? If not, it could and should.)

@SethTisue
Copy link
Member

Oh, i see on the ticket that maybe @bishabosha doesn't agree. wdyt @bishabosha ?

@SethTisue SethTisue requested a review from bishabosha December 22, 2023 02:34
@vreuter
Copy link
Contributor Author

vreuter commented Dec 22, 2023

Does the reference documentation link to the relevant section of the spec? If not, it could and should.)

Thanks for the context distinction b/w book and language spec and for suggesting the specific section links @SethTisue . I've added the more specific links here: 29c0b72

Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally I would suggest that you write a dedicated section, maybe you would like to come back and do that?

@bishabosha bishabosha merged commit 22ecdf0 into scala:main Jan 19, 2024
1 check failed
@vreuter
Copy link
Contributor Author

vreuter commented Jan 22, 2024

Ideally I would suggest that you write a dedicated section, maybe you would like to come back and do that?

@bishabosha would you mean in the Book (e.g., https://docs.scala-lang.org/scala3/book/types-intersection.html) or in the Reference (e.g., https://docs.scala-lang.org/scala3/reference/new-types/intersection-types.html#)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants