Rewrote compound types tour #742 #988
Conversation
|
PR 'Rewrote compound types tour #742' can be closed. |
_tour/self-types.md
Outdated
| @@ -24,12 +22,12 @@ trait User { | |||
| } | |||
|
|
|||
| trait Tweeter { | |||
| this: User => // reassign this | |||
| def tweet(tweetText: String) = println(s"$username: $tweetText") | |||
| this: User => // reassign this | |||
There was a problem hiding this comment.
Is there a reason this was changed from two spaces to a tab? I'd prefer keeping two-space indents.
There was a problem hiding this comment.
I think we're missing some of the changes in https://github.com/scala/docs.scala-lang/pull/742/files, did you rebase from https://github.com/travissarles/scala.github.com/tree/compound-types? If you use hub, you can fetch Travis's branches by doing git fetch travissarles and then doing a rebase for that branch. You can also copy-paste them if you want 😄.
| def hasNext: Boolean | ||
| def next(): A | ||
| } | ||
|
|
There was a problem hiding this comment.
Could we remove this extra space? 😄
There was a problem hiding this comment.
I assume by extra space you mean line #41.
There was a problem hiding this comment.
or extra space in 38,39.
_tour/traits.md
Outdated
| @@ -50,13 +54,13 @@ class IntIterator(to: Int) extends Iterator[Int] { | |||
|
|
|||
|
|
|||
| val iterator = new IntIterator(10) | |||
| println(iterator.next()) // prints 0 | |||
| println(iterator.next()) // prints 1 | |||
| iterator.next() // prints 0 | |||
There was a problem hiding this comment.
// return 0 rather than // prints 0?
|
I have replaced the tab with two spaces. |
|
Would pick #746.Any deadline for it?.
…On Sun, Jan 14, 2018 at 3:42 PM, Jorge ***@***.***> wrote:
@mghildiy <https://github.com/mghildiy> If you're looking for more, we
still need one more contributor in #746
<#746> 😄.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#988 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJly1ps1nP_Qofa75nd6G5NXqpICBAtBks5tKdMPgaJpZM4RdVBw>
.
|
|
Absolutely not, take your time. That's one of the gems that can actually be enlightening to work on if you're new to Scala; a solid understanding of implicits is paramount to become a better Scala programmer.. |
|
Let me know when you've addressed these comments and we merge @mghildiy. |
|
I have already made the change(Ttab to 2 spaces in self-types.md) as
suggested by @gmethvin and created the PR.
…On Sun, Jan 14, 2018 at 9:53 PM, Jorge ***@***.***> wrote:
Let me know when you've addressed these comments and we merge @mghildiy
<https://github.com/mghildiy>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#988 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJly1p6kDmW-J7Lrts0AL_mrM1rht45Gks5tKinkgaJpZM4RdVBw>
.
|
|
It seems you forgot to address my review comments though? |
|
Changes done |
|
thank you @mghildiy! |
No description provided.