This repository was archived by the owner on Feb 20, 2019. It is now read-only.
new binary IO interfaces for 0.10.x #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, Damien, for rebasing this against 0.10.x! |
There was a problem hiding this comment.
It'd be good to remove commented code. :-)
using ByteArrayOutputStream as default removing fastbinary and related tests removing ArrayOutput[Byte] (superseded by BinaryOutput) removing most of Utils bytebuffer throw overflow exception instead of reallocate pickleTo has a "free" input type
|
LGTM |
phaller
added a commit
that referenced
this pull request
Dec 11, 2014
new binary IO interfaces for 0.10.x
phaller
added a commit
that referenced
this pull request
Feb 5, 2015
new binary IO interfaces for 0.10.x
phaller
added a commit
that referenced
this pull request
Feb 5, 2015
new binary IO interfaces for 0.10.x
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'had some fun with git rebase.
ready for code review and merge.