Skip to content

fix JDK 6 on CI, and bump Scala and sbt and versions #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

fix JDK 6 on CI, and bump Scala and sbt and versions #172

wants to merge 5 commits into from

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Jan 31, 2019

modeled after @ashawley's scala/scala-xml#271

log for a green run from that PR, for reference: https://travis-ci.org/scala/scala-xml/builds/484411533

@SethTisue
Copy link
Member Author

SethTisue commented Jan 31, 2019

once this is green, but before I merge it, I should at least try to add openjdk11 to the Travis-CI matrix, too

@SethTisue
Copy link
Member Author

LOL FML

[error] /home/travis/build/scala/scala-collection-compat/project/LatestScala213.scala:4: object file is not a member of package java.nio
[error] import java.nio.file._
[error]                 ^
[error] one error found
[error] (compile:compileIncremental) Compilation failed

@SethTisue
Copy link
Member Author

SethTisue commented Jan 31, 2019

I'm just going to rip out this latest-Scala-2.13 stuff, since we're so close to RC1.

(It would make a cool sbt plugin for those wanting to use Scala nightlies — but, not tackling that myself, not right now anyway.)

@SethTisue
Copy link
Member Author

SethTisue commented Jan 31, 2019

gah, as I get deeper into this, I'm finding that Scalafix doesn't work on Java 6, and Scalafix stuff is all through the build now, since this repo has Scalafix rules as well as the library.

let's just drop JDK 6 support instead. probably the artifacts we build will actually work on Java 6. if somebody finds they don't, they can report it and we can fix it. probably the number of people who will want to use this library on JDK 6 is small/zero.

@SethTisue SethTisue closed this Jan 31, 2019
@SethTisue SethTisue mentioned this pull request Jan 31, 2019
@SethTisue
Copy link
Member Author

SethTisue commented Jan 31, 2019

version bumps are now #174

martijnhoekstra pushed a commit to martijnhoekstra/scala-collection-compat that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant