Add Array.from extension for scala 2.11 and 2.12 #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustedBones
force-pushed
the
array-extensions
branch
from
6afa36a to
f566425
Compare
|
review by @scala/collections ? |
He-Pin
reviewed
Sep 5, 2024
| @@ -357,6 +360,11 @@ private[compat] trait PackageShared { | |||
| new RandomExtensions(self) | |||
| } | |||
|
|
|||
| class ArrayExtensions(private val fact: Array.type) extends AnyVal { | |||
| def from[A: ClassTag](source: TraversableOnce[A]): Array[A] = | |||
| fact.apply(source.toSeq: _*) | |||
There was a problem hiding this comment.
source match {
case it: Iterable[A] => it.toArray[A]
case _ => it.iterator.toArray[A]
}
He-Pin
reviewed
Sep 5, 2024
| @@ -357,6 +360,11 @@ private[compat] trait PackageShared { | |||
| new RandomExtensions(self) | |||
| } | |||
|
|
|||
| class ArrayExtensions(private val fact: Array.type) extends AnyVal { | |||
RustedBones
force-pushed
the
array-extensions
branch
from
7eaa94b to
272af6e
Compare
SethTisue
approved these changes
Sep 7, 2024
|
Thank you! |
|
this has now shipped: https://github.com/scala/scala-collection-compat/releases/tag/v2.13.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the extension, code fails to compile for scala 2.11 and 2.12 with
Add missing extension to the compat package