Skip to content

JLine 3: fix //print #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SethTisue opened this issue Mar 6, 2020 · 2 comments · Fixed by scala/scala#8848
Closed

JLine 3: fix //print #692

SethTisue opened this issue Mar 6, 2020 · 2 comments · Fixed by scala/scala#8848
Assignees
@SethTisue
Labels
help-wanted t:repl JLine 3 upgrade (scala/scala#8036)
Milestone
2.13.2

Comments

@SethTisue
Copy link
Member

it sort of works but it ends up mangled:

scala> 2 + 2 //prin(2).+(2) // : Int(4)
@SethTisue SethTisue added prio:low t:repl JLine 3 upgrade (scala/scala#8036) labels Mar 6, 2020
@SethTisue SethTisue mentioned this issue Mar 6, 2020
Closed
9 tasks
@Jasper-M Jasper-M mentioned this issue Mar 30, 2020
Closed
@SethTisue
Copy link
Member Author

SethTisue commented Mar 31, 2020 •
edited
Loading

ReplCompletion.scala:

    // secret handshakes
    val slashPrint  = """.*// *print *""".r
    val slashPrintRaw  = """.*// *printRaw *""".r
    val slashTypeAt = """.*// *typeAt *(\d+) *(\d+) *""".r

might as well fix all three at once

but shhhh, they're SECRET

@SethTisue SethTisue self-assigned this Apr 3, 2020
SethTisue added a commit to SethTisue/scala that referenced this issue Apr 3, 2020
@SethTisue
REPL: JLine 3: get display of method signatures working again
244439c 
also gets //print and friends working again

fixes scala/scala-dev#696
fixes scala/scala-dev#692
@SethTisue SethTisue mentioned this issue Apr 3, 2020
Merged
@SethTisue SethTisue added this to the 2.13.2 milestone Apr 3, 2020
@SethTisue
Copy link
Member Author

I've added a commit to scala/scala#8848 that handles this at least reasonably okay

SethTisue added a commit to SethTisue/scala that referenced this issue Apr 6, 2020
@SethTisue
REPL: JLine 3: get display of method signatures working again
dd3cee4 
also gets //print and friends working again

fixes scala/scala-dev#696
fixes scala/scala-dev#692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SethTisue SethTisue

Labels
help-wanted t:repl JLine 3 upgrade (scala/scala#8036)
Projects
None yet
Milestone
2.13.2
Development

Successfully merging a pull request may close this issue.

REPL: JLine 3: fix various issues SethTisue/scala
1 participant
@SethTisue