-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add resources to main index and add license to other download files #497
Conversation
this would need a corresponding change in https://github.com/scala/make-release-notes, since that's how PRs such as #494 are created not sure if you feel like going that route. perhaps there's some easier to way address #448? |
Is I tried running:
but I got an error
From what I have gathered so far I think this PR should work. If I could do a dry-run of the next release then I would know for sure. The worst that would happen is that the Any ideas? |
Looks like |
in println(s"# don't forget to\n${scala.util.Properties.envOrElse("EDITOR", "mate")} ../scala-lang/download/index.md ../scala-lang/documentation/api.md ../scala-lang/_config.yml") so I guess index.md is hand-updated. I hit "merge" on this assuming it still fixed #448, but I see that it doesn't, actually. if I hit "merge" before you were ready, sorry about that. |
Is this still an issue? I don't see any problems on the production site. Granted it has been about a week since I looked at this. I took a trip to Hamburg. |
I'm not totally sure we got all the loose ends here, since I keep forgetting the details since I've only been looking at this once or twice a week. But I think Adriaan's manual fix took care of it, and then next time around, the manually updated file will be the basis for getting it right again in the next manual update. (It would be better if that were automated. I opened an issue on that: scala/make-release-notes#236.) |
Sounds great. I was dealing with the same problem. On a side note, I find it really interesting to work on something with so many different people. It is liberating to not have to know everything and to trust others. Thanks |
Possible fix for #448.