Skip to content

47 deg's redesign + some minor reorganization #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 214 commits into from
Jul 13, 2017

Conversation

travissarles
Copy link
Contributor

Javier de Silóniz Sandino added 30 commits January 9, 2017 17:26
…retweets get original tweet text and user information
…vated as there is no cross-origin support yet)
@heathermiller
Copy link
Member

I'd like to suggest some rewordings throughout the website, though the diff is too big to select individual files to make comments on. So it's probably best to make changes as follow-up commits.

A couple of questions though–I understand that the links are broken, but something weird is happening on the front page with blogs and events. That seems like it'd be unrelated to the linking issue, no? E.g.,
screen shot 2017-06-09 at 2 09 09 pm

There are also no blog articles appearing in the blog list. That could have something to do with linking though, I suppose.

@travissarles
Copy link
Contributor Author

Yes, I think the missing blog posts is an issue with linking. The problem is that Github pages uses travissarles.github.com/scala-lang/ as the baseurl but it's not getting picked up at generation time so all of the links are missing /scala-lang.

@travissarles
Copy link
Contributor Author

I can ask 47 Degrees how they got it running on Heroku.

@heathermiller
Copy link
Member

You can set the baseurl field in the _config.yml file so it generates correctly on travissarles.github.com

@travissarles
Copy link
Contributor Author

travissarles commented Jun 9, 2017

I tried that and it didn't work.

@heathermiller
Copy link
Member

@jarrodwb: the biggest issue I see in this PR is that the blog/events/etc are mixed up/not working. If you'd like to have a look, that'd probably be the first place to start. You could probably just make a PR to @travissarles's master branch fork of scala-lang since he's working on master anyway.

@heathermiller heathermiller merged commit e5d860f into scala:master Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants