Don't allude to mutating the Scala License #896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by the comments from fommil in https://gitter.im/scala/contributors?at=5afc0c2e41f54f22e233305e
_posts/2018-05-15-license-change.md
Outdated
| A number of contributors have expressed reservations about the asymmetry between our CLA (Apache v2) and our license (BSD-3). | ||
| This change aligns our license with our CLA. | ||
| This change fix this asymmetry. | ||
|
|
_posts/2018-05-15-license-change.md
Outdated
|
|
||
| # How is the license different? | ||
| # How is are the licenses different? |
|
cc @fommil |
SethTisue
approved these changes
May 17, 2018
fommil
approved these changes
May 17, 2018
fommil
reviewed
May 17, 2018
_posts/2018-05-15-license-change.md
Outdated
| @@ -5,27 +5,27 @@ title: "Intent to adopt the Apache License 2.0 for Scala" | |||
| by: Jorge Vicente Cantero and Adriaan Moors | |||
| --- | |||
|
|
|||
| Good news everyone! By popular demand, we intend to change the Scala license | |||
| Good news everyone! By popular demand, we intend to change the license that Scala is distributed under | |||
| from the [3-clause BSD License](https://github.com/scala/scala/blob/2.13.x/LICENSE) to the [Apache License v2.0](https://www.apache.org/licenses/LICENSE-2.0.html). | |||
| You have until 10 August 2018 to raise any objections (see below for contact info). | |||
|
|
|||
| # Is any of this legal advice? | |||
There was a problem hiding this comment.
I'd move this to a footnote, it's kind of weird and formal as the first point, and I'd say redundant. It's important for lawyers to include these disclaimers in their notes to their clients, or a doctor to a patient, if they are just laying out the options, but I don't think there is any ambiguity here.
|
Thanks @heathermiller! (how embarrassing) |
|
Incorporated Sam's advice on the "legal advice" bullet point, so please re-review given that. |
|
👍 LGTM! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the comments from fommil in https://gitter.im/scala/contributors?at=5afc0c2e41f54f22e233305e
WDYT?