Fixed up the front page training feed #919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh, I didn't notice the review-request. well, Heather can let us know if we should revert it. pre-merge, the body of https://www.scala-lang.org/training/ was blank, so it would hard to do worse :-) |
|
@SethTisue For this change I just focused on the front page under |
Closed
|
👍 opened #921 on it thank you Dylan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #698
It looks like the logic for the training page has changed a lot. I did my best on the front page, but the /training/ page is still missing the lightbend data.
I've also deleted the main.js file. It looks to me like we moved over to functions.js but never cleaned it up.