updated the /training page to include lightbend data #924
Conversation
…include lightbend data
|
is there a reviewer out there who understands this stuff, at least a little, and could take a look? |
|
By the way, @SethTisue I enjoyed your talk "You Are A Scala Contributor" at Scala Days. It's what inspired me to start picking up issues 😄 |
|
thanks for letting me know, that warms my heart! |
|
I tried previewing this locally but the training page was still blank. otoh, I think I recall that the training stuff never worked in local runs...? not 100% sure I'm going to go ahead and hit merge and let's just see... |
|
hmm, https://www.scala-lang.org/training/ is still blank... |
|
Yeah, I believe local runs don't work for training, since the php scripts aren't running (as far as I can see). For development I just served up the json from a local endpoint. https://www.scala-lang.org/training/ works for me, but has a bit of a lag. Are there any errors in your console? Maybe we could ditch the php proxying if we could convince the owner of https://www.lightbend.com/subscription/training.json to add some cors response headers? |
oh working now, maybe I just closed the tab too quickly last time 🎉 thank you for this |
we have an internal ticket on this at https://github.com/lightbend/lightbend.com/issues/1158 (private link) that has now been open for 2.5 years. I pinged again just now |
Fixes: #921
I moved the training data to it's own json file so we're not loading it for all pages that use
functions.jsI also refactored the training functions to work for both the front page and the
/trainingpage.Follow up work: #923 - support for On Demand training