Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use sbt-version-policy and declare versionScheme #164

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

SethTisue
Copy link
Member

No description provided.

@SethTisue
Copy link
Member Author

The Scala 3 jobs are hitting scalacenter/sbt-version-policy#62

and the Scala 2 jobs are getting

[info] scalacheck: mimaPreviousArtifacts is empty, not analyzing binary compatibility.
[error] sbt.librarymanagement.ResolveException: Error downloading default:scala-parallel-collections_2.13:1.0.1
[error]   Not found
[error]   not found: /home/travis/.ivy2/localdefault/scala-parallel-collections_2.13/1.0.1/ivys/ivy.xml
[error]   not found: https://repo1.maven.org/maven2/default/scala-parallel-collections_2.13/1.0.1/scala-parallel-collections_2.13-1.0.1.pom
[error] 	at lmcoursier.CoursierDependencyResolution.unresolvedWarningOrThrow(CoursierDependencyResolution.scala:258)

@julienrf note the incorrect URL — it's looking in default/scala-parallel-collections_2.13 when it should be org/scala-lang/modules/scala-parallel-collections_2.13. I could use your help here. is this is a bug in sbt-version-policy?

Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's looking in default/scala-parallel-collections_2.13 when it should be org/scala-lang/modules/scala-parallel-collections_2.13. I could use your help here. is this is a bug in sbt-version-policy?

Maybe, yes, or it could be an interaction between sbt-scala-module and sbt-version-policy, since both set MiMa settings.

It is not clear to me how the root project is defined, in this repository, but it’s organization setting is default, instead of org.scala-lang.modules.

A workaround is to invoke versionPolicyCheck only on the core project, which is the only one being published here.

@SethTisue SethTisue force-pushed the declare-version-scheme branch from 612e99b to d94ccea Compare March 5, 2021 17:40
@SethTisue SethTisue merged commit f3310b3 into scala:master Mar 5, 2021
@SethTisue SethTisue deleted the declare-version-scheme branch March 5, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants