Skip to content

lastNoSuccessVar is a source of mystery #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
svalaskevicius opened this issue Mar 10, 2017 · 1 comment
Closed

lastNoSuccessVar is a source of mystery #107

svalaskevicius opened this issue Mar 10, 2017 · 1 comment

Comments

@svalaskevicius
Copy link
Contributor

svalaskevicius commented Mar 10, 2017

what is the purpose of lastNoSuccessVar?

I've just had an intensive debugging session trying to figure out why is the parser reviving a harmless parse failure that should have been resolved by the | operator (and indeed it has been). In addition, by showing an irrelevant failure, this variable has hidden the real error just before the end of parser's input.

For now, I've cloned the phrase function to my parser, doing the same just w/o the mutable state to hold false errors, however, should the variable usage be removed from the library or are there any use cases where it is helpful? (and can they be solved in a referentially transparent way?)

@svalaskevicius
Copy link
Contributor Author

replaced by #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant