Skip to content

publish for Scala 2.13.0-M5 #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SethTisue opened this issue Sep 11, 2018 · 8 comments
Closed

publish for Scala 2.13.0-M5 #170

SethTisue opened this issue Sep 11, 2018 · 8 comments
Assignees

Comments

@SethTisue
Copy link
Member

SethTisue commented Sep 11, 2018

for reference, here's how M4 publishing went down: #151

version bumping for M5 happened at #168

@SethTisue SethTisue self-assigned this Sep 11, 2018
@SethTisue
Copy link
Member Author

SethTisue commented Sep 11, 2018

okay so first we need to assess what version we are publishing and what changes need to be included

we would prefer to just republish 1.1.1 for M5 rather than have to go to 1.1.2. can we do that?

the Scala 2.13 community build is just using the plain 1.1.x branch, so that's a good sign

looking at git log -p v1.1.1..1.1.x, there is a user-visible change, namely #108. we shouldn't include that if we want to keep the version number the same

but I don't see any commits we need to include except for the M5 version bumps (#168, 61da24e)

so I think we can just cherry-pick 61da24e onto the v1.1.1 commit and tag it as v1.1.1#2.13.10-M5#8

I'll try it.

@SethTisue
Copy link
Member Author

SethTisue commented Sep 11, 2018

I did:

git checkout v1.1.1
git cherry-pick 61da24e6987f49ba6f2572385ce8aa515e932da9
git tag -a v1.1.1#2.13.0-M5#8
git push --tags origin

this resulted in https://travis-ci.org/scala/scala-parser-combinators/builds/427431583 of which the JDK 8 job is https://travis-ci.org/scala/scala-parser-combinators/jobs/427431586

but then something went wrong in the JDK 6 job (https://travis-ci.org/scala/scala-parser-combinators/jobs/427431584) and it ran on Java 8 not 6, so both jobs published stuff to staging. I think the safest course is to delete those staging repos, fix the cause of the JDK version problem, then start again.

@SethTisue
Copy link
Member Author

SethTisue commented Sep 11, 2018

staging repos (orgscala-lang-1603 and orgscala-lang-1604) dropped via Sonatype web UI (as user lamp)

v1.1.1#2.13.0-M5#8 tag deleted via GitHub web UI

@SethTisue
Copy link
Member Author

SethTisue commented Sep 11, 2018

as for why the JDK 6 job ran on JDK 8, I thought we addressed that already at #156

the job log says

Switching to OpenJDK6 (java-1.6.0-openjdk-amd64), JAVA_HOME will be set to /usr/lib/jvm/java-6-openjdk-amd64
update-java-alternatives: directory does not exist: /usr/lib/jvm/java-1.6.0-openjdk-amd64

oh, I know, #156 is part of the 1.1.x branch but isn't part of the v1.1.1 tag, so that's my mistake. I need to cherry-pick 6c7679b

@SethTisue
Copy link
Member Author

ok so from the same shell prompt as before I did

git tag -d v1.1.1#2.13.0-M5#8
git cherry-pick 6c7679ba609029f18ee987db716a565755b62d02
git push --tags origin

the new build on Travis is https://travis-ci.org/scala/scala-parser-combinators/builds/427437124

the JDK 6 job, https://travis-ci.org/scala/scala-parser-combinators/jobs/427437125, now says Not publishing v1.1.1#2.13.0-M5#8 on Java version 6. 👍

and the JDK 8 job, https://travis-ci.org/scala/scala-parser-combinators/jobs/427437126, staged artifacts to Sonatype 👍

as usual it's nondeterministic how many staging repos we end up with. this time the JVM artifacts ended up in orgscala-lang-1605, the JS artifacts in orgscala-lang-1606

I closed both repos via the Sonatype web UI. I'll sanity check the artifacts before actually releasing them

@SethTisue
Copy link
Member Author

made a blank sbt project with just:

scalaVersion := "2.13.0-M5"
libraryDependencies +=
    "org.scala-lang.modules" %% "scala-parser-combinators"   % "1.1.1"

and verified that resolution fails: [error] (update) sbt.librarymanagement.ResolveException: unresolved dependency: org.scala-lang.modules#scala-parser-combinators_2.13.0-M5;1.1.1: not found

then I added

resolvers += "staging" at                                                                                              
  "https://oss.sonatype.org/content/repositories/staging"                                                              

and re-tried and got:

[info] downloading https://oss.sonatype.org/content/repositories/staging/org/scala-lang/modules/scala-parser-combinators_2.13.0-M5/1.1.1/scala-parser-combinators_2.13.0-M5-1.1.1.jar ...

then I ran console, pasted in the sample code from the repo README, and ran:

Welcome to Scala 2.13.0-M5 (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_181).

...

scala> TestSimpleParser.main(Array())
Word <johnny> occurs with frequency 121

so looks like we're good.

@SethTisue
Copy link
Member Author

SethTisue commented Sep 11, 2018

I hit "release" on both staging repos in the Sonatype web UI, so the artifacts should show up on Maven Central soon 🚀

watch this space: https://repo1.maven.org/maven2/org/scala-lang/modules/scala-parser-combinators_2.13.0-M5/1.1.1/

@SethTisue
Copy link
Member Author

happy little artifacts

screen shot 2018-09-11 at 4 51 11 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant