Update to sbt-scala-module 1.0.12 #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrytz
changed the title
lrytz
force-pushed
the
sbt-osgi-0.9.1
branch
4 times, most recently
from
62d3150 to
573b876
Compare
lrytz
changed the title
Add osgi settings only to the `JVM` project. In the JS project they caused the resulting jar to be empty. Fixes scala#119 Adds MiMa checking to the JS jar. Minor cleanups in the build definition.
|
@gourlaysama this is ready for review now. Once it's merged we should release 1.0.7. I tested the fix for #119 locally |
gourlaysama
approved these changes
Jul 17, 2017
lrytz
commented
Jul 17, 2017
| settings( | ||
| name := "scala-parser-combinators-root", | ||
| repoName := "scala-parser-combinators", |
There was a problem hiding this comment.
uh, that was probably a mistake from my part, i think it should stay name. the plugin then sets repoName := name.value, which could be overridden if necessary.
There was a problem hiding this comment.
It doesn't cause harm because the name is picked up from the project name, so you get
> name
[info] scala-parser-combinatorsJS/*:name
[info] scala-parser-combinators
[info] scala-parser-combinatorsJVM/*:name
[info] scala-parser-combinators
But we should fix it anyway.
Why not be 1.0.7 released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add osgi settings only to the
JVMproject. In the JS project theycaused the resulting jar to be empty.
Fixes #119
Adds MiMa checking to the JS jar.
Minor cleanups in the build definition.