Skip to content

remove long-deprecated scala.util.parsing.json #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2019
Merged

remove long-deprecated scala.util.parsing.json #227

merged 1 commit into from
Jul 19, 2019

Conversation

SethTisue
Copy link
Member

fixes #221

@SethTisue SethTisue requested a review from Philippus July 8, 2019 18:41
@SethTisue
Copy link
Member Author

@Philippus the only hesitation I have here is that some of the removed tests might not actually about JSON support, they might just be using the JSON support as a convenient way to test something else. wdyt?

@Philippus
Copy link
Member

Philippus commented Jul 8, 2019 •
edited
Loading

I did some digging:

t4929.scala was introduced in scala/scala#124.
See also #108 (comment). Maybe it can be removed anyway?

The json-part of UnitTestIO.scala was introduced in scala/scala@302612f

@SethTisue
Copy link
Member Author

@Philippus thanks. I don't see a need to dig further

@SethTisue SethTisue merged commit 9e3dba7 into scala:1.2.x Jul 19, 2019
@SethTisue SethTisue deleted the remove-json branch July 19, 2019 01:58
@SethTisue
Copy link
Member Author

we'll see what NAUGHTY, BAD projects in the Scala community build were still using this somewhere (hopefully none)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Philippus Philippus Awaiting requested review from Philippus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drop util.parsing.json
2 participants
@SethTisue @Philippus