Skip to content

Conversation

@lolgab
Copy link
Contributor

@lolgab lolgab commented Jul 24, 2019

No description provided.

@SethTisue
Copy link
Member

review by @ekrich, perhaps?

@ekrich
Copy link

ekrich commented Jul 24, 2019

The .travis.yml, build.sbt with the admin/build.sh is quite the combo.

Copy link

@ekrich ekrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lolgab

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lolgab!

@eed3si9n eed3si9n merged commit cc56de2 into scala:1.2.x Jul 26, 2019
@lolgab
Copy link
Contributor Author

lolgab commented Jul 27, 2019

It's been a pleasure, you are welcome guys, thank you for the ready review and merge 👍

@lolgab lolgab deleted the 1.2.x branch July 27, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants