-
Notifications
You must be signed in to change notification settings - Fork 131
Add dotty to cross-build #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed one error by adding a type annotation |
Managed to get compiling and testing to work, not sure (yet) what the next failure is about. |
Got a green build. Closes #230 by the way. |
shared/src/main/scala/scala/util/parsing/combinator/PackratParsers.scala
Outdated
Show resolved
Hide resolved
shared/src/main/scala/scala/util/parsing/combinator/Parsers.scala
Outdated
Show resolved
Hide resolved
@SethTisue Do you have time to take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks for tackling this! pretty exciting to see the upgrade starting to work its way through the ecosystem 💪
Also added to the dotty community build in scala/scala3#8604. |
I'm down to three errors on this one: