Skip to content

Add dotty to cross-build #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 18, 2020
Merged

Add dotty to cross-build #270

merged 14 commits into from
Mar 18, 2020

Conversation

Philippus
Copy link
Member

@Philippus Philippus commented Mar 8, 2020

I'm down to three errors on this one:

[error] -- [E007] Type Mismatch Error: /home/travis/build/scala/scala-parser-combinators/shared/src/main/scala/scala/util/parsing/combinator/PackratParsers.scala:110:39 
[error] 110 |        case in: PackratReader[_] => q(in)
[error]     |                                       ^^
[error]     |                 Found:    (in : PackratParsers.this.PackratReader[_])
[error]     |                 Required: PackratParsers.this.Input
[error] -- [E008] Member Not Found Error: /home/travis/build/scala/scala-parser-combinators/shared/src/main/scala/scala/util/parsing/combinator/Parsers.scala:667:7 
[error] 667 |    es.foldRight[Parser[List[Elem]]](success(Nil)){(x, pxs) => accept(x) ~ pxs ^^ mkList}
[error]     |    ^^^^^^^^^^^^
[error]     |    value foldRight is not a member of ES
[error] -- [E008] Member Not Found Error: /home/travis/build/scala/scala-parser-combinators/shared/src/main/scala/scala/util/parsing/combinator/syntactical/StandardTokenParsers.scala:32:15 
[error] 32 |    if(lexical.reserved.contains(chars) || lexical.delimiters.contains(chars)) super.keyword(chars)
[error]    |       ^^^^^^^^^^^^^^^^
[error]    |      value reserved is not a member of StandardTokenParsers.this.Tokens

@Philippus
Copy link
Member Author

Fixed one error by adding a type annotation

@Philippus
Copy link
Member Author

Managed to get compiling and testing to work, not sure (yet) what the next failure is about.

@Philippus
Copy link
Member Author

Got a green build.

Closes #230 by the way.

@Philippus Philippus requested a review from smarter March 9, 2020 08:17
@Philippus
Copy link
Member Author

@SethTisue Do you have time to take another look?

Copy link
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks for tackling this! pretty exciting to see the upgrade starting to work its way through the ecosystem 💪

@Philippus Philippus merged commit e26d523 into scala:1.2.x Mar 18, 2020
@Philippus Philippus deleted the add-dotty branch March 18, 2020 07:22
@Philippus Philippus mentioned this pull request Apr 3, 2020
@Philippus
Copy link
Member Author

Also added to the dotty community build in scala/scala3#8604.

@arashi01 arashi01 mentioned this pull request Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants