Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check for scala versions anymore for scala native #447

Merged
merged 4 commits into from
Feb 3, 2022

Conversation

Philippus
Copy link
Member

@Philippus Philippus commented Feb 2, 2022

I think this will help solve the empty jars problem in #444. I had to update scala 3.0.2 to 3.1.1 as well to make the build succeed.

@Philippus Philippus force-pushed the issue-444 branch 2 times, most recently from de2d168 to d7ae2c6 Compare February 2, 2022 20:38
@SethTisue
Copy link
Member

I think it's fine to use Scala 3.1. It means users of our next library version won't be able to use it on Scala 3.0, but I think that's fine, let them move to 3.1. (Scala 3.1.2-RC1 adds -Yscala-release which aims to add this kind of forward-compatibility, but I think it's too new/experimental for us to rely on.)

I think the check for JDK 1.6 can be dropped; we no longer build or test on JDK 6 or 7.

I'm curious if the test := {} is still needed.

Did you look to see if publishLocal publishes non-empty JARs?

@Philippus
Copy link
Member Author

publishLocal indeed published empty jars, after this change not anymore.
I've dropped jdk 6 and enabled the tests for scala native.

@Philippus Philippus merged commit b097700 into scala:main Feb 3, 2022
@Philippus Philippus deleted the issue-444 branch February 3, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants