make sbt-version-policy allow us to release 1.1.3(-RCx) #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to release 1.1.x patch release, we must: * make some source adjustments to preserve forward binary compatibility * change our `versionPolicyIntention` to require bidirectional compatibility, otherwise sbt-version-policy won't let us call it 1.1.3
SethTisue
changed the title
|
note that normally I would be happy to just call it 1.2.0 to avoid the bidirectional MiMa checking, but unfortunately we did a 1.2.0-M1 and 1.2.0-RC1 before eventually deciding to call the final release 2.0.0 rather than 1.2.0 |
I'm going to resolve this by disabling the version checks for the JS artifacts. |
|
now I'm getting a bunch of |
|
closing for now, as we're currently pursuing a different path with the client (namely, trying to make 2.0 work in their codebase) this PR could always be revived if we change our minds; closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to release 1.1.x patch release, we must:
versionPolicyIntentionto require bidirectional compatibility, otherwise sbt-version-policy won't let us call it 1.1.3