Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish as 2.0.0 without M2 suffix? #51

Closed
benhutchison opened this issue Nov 13, 2016 · 22 comments
Closed

Publish as 2.0.0 without M2 suffix? #51

benhutchison opened this issue Nov 13, 2016 · 22 comments

Comments

@benhutchison
Copy link
Contributor

I maintain legacy lib ScalaSwingContrib and are publishing for 2.12. Was surprised to find only a milestone builds for 2.12.x.

Seems there isn't any likely prospect of much more work on Swing lib, so could we re-publish as 2.0.0? The M2 suffix suggests expected changes coming...

Testing Ive done with M2 on 2.12:

Unit tests for ScalaSwingContrib plus manual testing of its 3 demos all look good

 [1] scalaswingcontrib.test.ColorChooserDemo
 [2] scalaswingcontrib.test.TreeDemo
 [3] scalaswingcontrib.test.group.GroupLayoutDemo
@SethTisue
Copy link
Member

SGTM — I think a PR on this would be accepted.

also, would you like to be a community maintainer of this repo? (@andy1138 are you still involved?)

@andy1138
Copy link
Contributor

Hi Ben (and always Seth)

It would be great if you wanted to be a community maintainer, one of the
biggest problems I've had is that I get to code review and help other
people add changes but when I want to change something then its really hard
to find somebody else to do a code review or 'do you think this is a good
idea' conversation with. This is one of the reasons why very little has
happened to swing (along with a lot of the other problems are really
hard/impossible to do)

I will spend some time over the weekend and get a build without the M2
suffix.

And then we can get the others into the swing lib ( I know ColorChooserDemo
is already in scalaswing as it has a truly awesome author, but it would be
good to add Tree and GroupPane :-) )

On 14 November 2016 at 19:41, Seth Tisue notifications@github.com wrote:

SGTM — I think a PR on this would be accepted.

also, would you like to be a community maintainer of this repo? (@andy1138
https://github.com/andy1138 are you still involved?)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#51 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAbxqFRgqTVTljZ9hz0HDLvTUQ84kCTCks5q-Ll9gaJpZM4KwlZj
.

Tanis Systems Limited is a company registered in England and Wales.
Registered number: 5464771. Registered office: 2 Avondale House, 264
Croydon Road, Caterham, CR3 6QJ, VAT 238866167

@benhutchison
Copy link
Contributor Author

My view is that Swing is a legacy platform. Most users will have existing
systems that they need to keep running. As I see it, thats the "target
audience". So I envisage its mainly about merging bug fixes and small
tweaks, plus getting releases out each time scala breaks binary compat.

If that aligns with your expectation, then yes Id be happy to be a
community maintainer.

On Tue, Nov 15, 2016 at 6:41 AM, Seth Tisue notifications@github.com
wrote:

SGTM — I think a PR on this would be accepted.

also, would you like to be a community maintainer of this repo? (@andy1138
https://github.com/andy1138 are you still involved?)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#51 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAF05JlKte-HMSmc8SGbrnFixs7854ctks5q-Ll9gaJpZM4KwlZj
.

@SethTisue
Copy link
Member

yes, that sounds fine. someone else would still be free to come along and take a more active/aggressive approach to improving the library, but what you describe is perfectly acceptable ambition level to qualify as a maintainer.

@SethTisue
Copy link
Member

I've sent you an invite for https://github.com/orgs/scala/teams/community-maintainers — once you've accepted, may I suggest you send a PR adding yourself to the readme?

@andy1138
Copy link
Contributor

Hi ben, great to see you've joined and I've already pulled the first code
change.

I've done a pull request to remove gitter. I also thing haveing this is
'overkill' and just gives a chance to 'kick the tires' and check if things
work.

Guess the first thing is to just removed the M2 and get a build using 2.12
out :-)

On the admin side, the only thing is that anyone who adds code has to sign
the scala CLA and there is a little url to check this at
http://www.lightbend.com/contribute/cla/scala/check/benhutchison (I may be
wrong but dont think the build process checks)

On 16 November 2016 at 19:10, Seth Tisue notifications@github.com wrote:

I've sent you an invite for https://github.com/orgs/scala/
teams/community-maintainers — once you've accepted, may I suggest you
send a PR adding yourself to the readme?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#51 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAbxqGtdE4eUpnIpWzeMkb_ubh4Jmedfks5q-1UfgaJpZM4KwlZj
.

Tanis Systems Limited is a company registered in England and Wales.
Registered number: 5464771. Registered office: 2 Avondale House, 264
Croydon Road, Caterham, CR3 6QJ, VAT 238866167

@SethTisue
Copy link
Member

I may be
wrong but dont think the build process checks

you are correct. it's scala/scala-dev#269

@SethTisue
Copy link
Member

@benhutchison still interested?

@benhutchison
Copy link
Contributor Author

@SethTisue Yes, still interested.

AFAICT steps to resolve this are:

1 Scala version update #56
2 Person with Scala's sonatype credentials edits build.sbt locally changes version := "2.0.0"
3 That person then sbt +publishSigned followed by maven repo release (manually I guess? ..Ive always use https://github.com/xerial/sbt-sonatype myself).
4 After publish do they then increment the version to version := "2.0.1-SNAPSHOT" ?

As a committer I only do the first part (I think?). Does that fit with your expectation? Or if otherwise, is there some maven release doc for scala artifacts you could point me at?

@SethTisue
Copy link
Member

publishing is tag based — you push a release tag, Travis does the rest (almost, see below). the version number comes from the tag rather than from the sbt setting. this stuff is provided by scala-module-plugin. the necessary sonatype credentials are already in .travis.yml, encrypted. see also admin/build.sh which is what actually does the publishing.

the only part you need the Scala team for is when you ask us to (perhaps after doing a last sanity check of our own) manually close and release the staging repos on sonatype, to allow the artifacts to proceed to Maven Central

@SethTisue SethTisue mentioned this issue Jan 10, 2017
Open
@SethTisue
Copy link
Member

P.S. I'm sorry there isn't better documentation on this. there are only a handful of you module maintainers, so we've been a bit lazy and just helped people one at a time, like we did here. I've opened a ticket about it here: scala/sbt-scala-module#16

@benhutchison
Copy link
Contributor Author

benhutchison commented Jan 16, 2017 via email

@SethTisue
Copy link
Member

hmm, looks like the repo has to be closed before it becomes accessible

so, I closed it in the web UI, and it's now accessible at https://oss.sonatype.org/content/repositories/orgscala-lang-1388/ for you to do pre-release sanity checking

@benhutchison
Copy link
Contributor Author

benhutchison commented Jan 18, 2017 via email

@SethTisue
Copy link
Member

released via Sonatype web UI. the artifacts should show up on Maven Central soon

@SethTisue
Copy link
Member

would you like to submit a scala/scala PR bumping the scala-swing version there...?

This was referenced Jan 24, 2017
Closed
Merged
@SethTisue
Copy link
Member

scala/scala#5678 thanks!

@SethTisue
Copy link
Member

afaik, the only missing piece before we can close this ticket is adding release notes to https://github.com/scala/scala-swing/releases/tag/v2.0.0

@SethTisue
Copy link
Member

@benhutchison ping

@benhutchison
Copy link
Contributor Author

benhutchison commented Aug 2, 2017 via email

@SethTisue
Copy link
Member

thx!

@SethTisue
Copy link
Member

I'm a bit afraid people will think that 2.0.0 works only with those specific Scala versions, so I changed it to just "2.11 and 2.12"

@SethTisue SethTisue mentioned this issue Feb 16, 2018
Open
@Sciss Sciss mentioned this issue Jun 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benhutchison @SethTisue @andy1138