Skip to content

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Oct 1, 2021

and:

  • upgrade sbt to 1.5.5 (was 1.5.2)
  • upgrade sbt-scala-module to 3.0.0 (was 2.3.0)
  • upgrade Scala versions (2.12.15, 2.13.6, 3.0.2)
  • upgrade ScalaTest to 3.2.10 (was 3.2.9)
  • add JDK 17 to CI matrix
  • a few minor cleanups

context is scala/scala-dev#785

@SethTisue SethTisue force-pushed the bye-bye-travis-ci branch 2 times, most recently from 0ff1ed6 to 4957a71 Compare October 1, 2021 01:29
@SethTisue SethTisue marked this pull request as ready for review October 1, 2021 01:34
@SethTisue SethTisue requested a review from Sciss October 1, 2021 01:34
@SethTisue
Copy link
Member Author

SethTisue commented Oct 1, 2021

@Sciss I am also adding the publishing secrets to the GitHub Actions settings, so we should be all set to go for publishing. I don't think we need to test that aspect... if it doesn't work when the time comes, we'll deal with it.


lazy val commonSettings = Seq(
scalacOptions ++= Seq("-deprecation", "-feature"),
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sbt-scala-module sets these, so we don't need to

.settings(commonSettings)
.settings(
scalaVersion := (swing / scalaVersion).value,
run / fork := true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confident this isn't needed

@@ -1,2 +1 @@
addSbtPlugin("org.scala-lang.modules" % "sbt-scala-module" % "2.3.0")
addSbtPlugin("ch.epfl.scala" % "sbt-version-policy" % "1.0.1")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sbt-scala-module now includes sbt-version-policy

Copy link
Contributor

@Sciss Sciss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

and:

* upgrade sbt to 1.5.5 (was 1.5.2)
* upgrade sbt-scala-module to 3.0.0 (was 2.3.0)
* upgrade Scala versions (2.12.15, 2.13.6, 3.0.2)
* upgrade ScalaTest to 3.2.10 (was 3.2.9)
* add JDK 17 to CI matrix
* a few other minor cleanups
@SethTisue SethTisue merged commit c7616eb into work Oct 1, 2021
@SethTisue SethTisue deleted the bye-bye-travis-ci branch October 1, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants