Skip to content

NodeBuffer does print as ArrayBuffer #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jschmuec opened this issue Oct 18, 2016 · 2 comments
Closed

NodeBuffer does print as ArrayBuffer #115

jschmuec opened this issue Oct 18, 2016 · 2 comments
Milestone
1.1.0

Comments

@jschmuec
Copy link
Contributor

new scala.xml.NodeBuffer() &+ scala.xml.Text("Text 1")

should print as:

NodeBuffer(Text 1)

but prints as

ArrayBuffer(Text 1).

I think you just need to add

override def stringPrefix: String = "NodeBuffer"
@biswanaths
Copy link
Contributor

@jschmuec : Thank you for reporting this.

ashawley added a commit to ashawley/scala-xml that referenced this issue Oct 21, 2016
@ashawley
Add test of NodeBuffer for scala#115
b038452
ashawley pushed a commit to ashawley/scala-xml that referenced this issue Oct 21, 2016
@jschmuec @ashawley
Fix scala#115 with override def stringPrefix = "NodeBuffer"
93a1e2b
ashawley added a commit to ashawley/scala-xml that referenced this issue Dec 1, 2016
@ashawley
Add test of NodeBuffer for scala#115
21589fe
ashawley pushed a commit to ashawley/scala-xml that referenced this issue Dec 1, 2016
@jschmuec @ashawley
Fix scala#115 with override def stringPrefix = "NodeBuffer"
66c0810
ashawley added a commit to ashawley/scala-xml that referenced this issue Feb 4, 2017
@ashawley
Add test of NodeBuffer for scala#115
452a7d5
ashawley pushed a commit to ashawley/scala-xml that referenced this issue Feb 4, 2017
@jschmuec @ashawley
Fix scala#115 with override def stringPrefix = "NodeBuffer"
80e2e55
ashawley added a commit to ashawley/scala-xml that referenced this issue Feb 4, 2017
@ashawley
Add test of NodeBuffer for scala#115
ed2ffc3
ashawley pushed a commit to ashawley/scala-xml that referenced this issue Feb 4, 2017
@jschmuec @ashawley
Fix scala#115 with override def stringPrefix = "NodeBuffer"
0ee849e
ashawley added a commit to ashawley/scala-xml that referenced this issue Feb 4, 2017
@ashawley
Add test of NodeBuffer for scala#115
2629754
ashawley pushed a commit to ashawley/scala-xml that referenced this issue Feb 4, 2017
@jschmuec @ashawley
Fix scala#115 with override def stringPrefix = "NodeBuffer"
463f3af
ashawley added a commit to ashawley/scala-xml that referenced this issue Feb 7, 2017
@ashawley
Add test of NodeBuffer for scala#115
87b41c8
ashawley pushed a commit to ashawley/scala-xml that referenced this issue Feb 7, 2017
@jschmuec @ashawley
Fix scala#115 with override def stringPrefix = "NodeBuffer"
f1fd082
ashawley added a commit to ashawley/scala-xml that referenced this issue Feb 15, 2017
@ashawley
Add test of NodeBuffer for scala#115
e18b3b9
ashawley pushed a commit to ashawley/scala-xml that referenced this issue Feb 15, 2017
@jschmuec @ashawley
Fix scala#115 with override def stringPrefix = "NodeBuffer"
80af95b
ashawley added a commit to ashawley/scala-xml that referenced this issue Apr 25, 2017
@ashawley
Add test of NodeBuffer for scala#115
b402ff8
ashawley pushed a commit to ashawley/scala-xml that referenced this issue Apr 25, 2017
@jschmuec @ashawley
Fix scala#115 with override def stringPrefix = "NodeBuffer"
0d77a26
ashawley added a commit to ashawley/scala-xml that referenced this issue Apr 26, 2017
@ashawley
Add test of NodeBuffer for scala#115
88c6c82
ashawley pushed a commit to ashawley/scala-xml that referenced this issue Apr 26, 2017
@jschmuec @ashawley
Fix scala#115 with override def stringPrefix = "NodeBuffer"
dea020f
ashawley added a commit to ashawley/scala-xml that referenced this issue Apr 26, 2017
@ashawley
Add test of NodeBuffer for scala#115
6f11077
ashawley pushed a commit to ashawley/scala-xml that referenced this issue Apr 26, 2017
@jschmuec @ashawley
Fix scala#115 with override def stringPrefix = "NodeBuffer"
48c1589
ashawley added a commit to ashawley/scala-xml that referenced this issue Apr 28, 2017
@ashawley
Add test of NodeBuffer for scala#115
3d05fbe
ashawley pushed a commit to ashawley/scala-xml that referenced this issue Apr 28, 2017
@jschmuec @ashawley
Fix scala#115 with override def stringPrefix = "NodeBuffer"
9ad92da
ashawley added a commit to ashawley/scala-xml that referenced this issue Apr 28, 2017
@ashawley
Add test of NodeBuffer for scala#115
3e5f356
ashawley pushed a commit to ashawley/scala-xml that referenced this issue Apr 28, 2017
@jschmuec @ashawley
Fix scala#115 with override def stringPrefix = "NodeBuffer"
5b04c5e
ashawley added a commit to ashawley/scala-xml that referenced this issue May 5, 2017
@ashawley
Add test of NodeBuffer for scala#115
8bbd87d
ashawley pushed a commit to ashawley/scala-xml that referenced this issue May 5, 2017
@jschmuec @ashawley
Fix scala#115 with override def stringPrefix = "NodeBuffer"
029a6ca
ashawley added a commit to ashawley/scala-xml that referenced this issue May 6, 2017
@ashawley
Add test of NodeBuffer for scala#115
8005be6
ashawley pushed a commit to ashawley/scala-xml that referenced this issue May 6, 2017
@jschmuec @ashawley
Fix scala#115 with override def stringPrefix = "NodeBuffer"
8d8398b
ashawley added a commit to ashawley/scala-xml that referenced this issue May 12, 2017
@ashawley
Add test of NodeBuffer for scala#115
ff397e5
ashawley pushed a commit to ashawley/scala-xml that referenced this issue May 12, 2017
@jschmuec @ashawley
Fix scala#115 with override def stringPrefix = "NodeBuffer"
fcad191
ashawley added a commit to ashawley/scala-xml that referenced this issue May 24, 2017
@ashawley
Add test of NodeBuffer for scala#115
831fdeb
ashawley pushed a commit to ashawley/scala-xml that referenced this issue May 24, 2017
@jschmuec @ashawley
Fix scala#115 with override def stringPrefix = "NodeBuffer"
9a54c04
ashawley added a commit to ashawley/scala-xml that referenced this issue May 24, 2017
@ashawley
Add test of NodeBuffer for scala#115
000e069
ashawley pushed a commit to ashawley/scala-xml that referenced this issue May 24, 2017
@jschmuec @ashawley
Fix scala#115 with override def stringPrefix = "NodeBuffer"
c080d7d
ashawley added a commit to ashawley/scala-xml that referenced this issue May 24, 2017
@ashawley
Add test of NodeBuffer for scala#115
3bbc63e
ashawley added a commit that referenced this issue May 24, 2017
@ashawley
Merge pull request #117 from ashawley/fix-115-NodeBuffer-toString
ddc4bb0 
Fix #115 NodeBuffer.toString
@ashawley
Copy link
Member

This was fixed in #117. Thanks for reporting this. With any luck, this will be released in 1.0.7 relatively soon.

@ashawley ashawley added this to the 1.1.0 milestone Oct 7, 2017
@ashawley ashawley mentioned this issue Oct 9, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
3 participants
@biswanaths @ashawley @jschmuec