Do not ignore XML comments when parsing

[dubinsky]

scala-xml uses scala.xml.Comment to represent XML comments if they are present in the XML literals, and allows constructing comment nodes explicitly; when parsing XML not from a literal, scala.xml.factory.XMLLoader does not set
an instance of org.xml.sax.ext.LexicalHandler as an "http://xml.org/sax/properties/lexical-handler" property on the underlying parser, and does not provide any factory methods that such lexical handler could call from its comment() method.

As a result, comments present in the XML being loaded get ignored.

Are there any plans to fix this?

Thanks!

[SethTisue]

There don’t seem to be any other tickets about this.

In general, there aren't "plans" for scala-xml except to keep on merging volunteer pull requests that come in and keep doing releases.

[dubinsky]

... keep on merging volunteer pull requests that come in ...

Here is one then: #549; please take a look ;)

[ashawley]

I'll take a look. Thanks for contributing this.

[ashawley]

Since it's new behavior, I guess this could be part of a 2.1.0 release of scala-xml.

[ashawley]

The patch introduces some non-trivial changes to the the library's core parsing infrastructure, but there's no other way to do it. It's worth accepting, IMO. Thanks again for the contribution.

[dubinsky]

Since it's new behavior, I guess this could be part of a 2.1.0 release of scala-xml.

Isn't every fixed bug new behavior? :)

[dubinsky]

@ashawley

It's worth accepting, IMO. Thanks again for the contribution.

Thank you for your kind words!
I have some follow-up fixes planned (CDATA sections, processing instructions and the like).
Will my pull request be merged so that I can build on it or do you prefer everything in one pull request?
Thanks!

[ashawley]

Isn't every fixed bug new behavior? :)

True, if fixing comments was a bug fix it would be 2.0.2, but your change is more involved.

Will my pull request be merged so that I can build on it or do you prefer everything in one pull request?

Yes, we'll try to get it merged soon. Then your further fixes can be new pull requests.

[dubinsky]

@ashawley

Will my pull request be merged so that I can build on it or do you prefer everything in one pull request?

Yes, we'll try to get it merged soon. Then your further fixes can be new pull requests.

Great, thanks!