Skip to content

Re-enable versionPolicyCheck #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ashawley opened this issue Aug 10, 2022 · 2 comments · Fixed by #641
Closed

Re-enable versionPolicyCheck #617

ashawley opened this issue Aug 10, 2022 · 2 comments · Fixed by #641
Labels
help wanted

Comments

@ashawley
Copy link
Member

Discussing scala/bug#12632 I was reminded that the Mima plugin and the sbt-version-policy plugin was relaxed and put back and relaxed again a couple of times:

It should probably be turned back on or at the very least conditionally so.

Currently it is:

    // should be reverted to Compatibility.BinaryAndSourceCompatible after 2.2.0 is released
    versionPolicyIntention := Compatibility.None,
@ashawley
Copy link
Member Author

I'm less familiar with the build, but I believe:

  1. it should be able to be turned back on for Java,
  2. but can only be BinaryCompatible for Scala.js
  3. and can't be checked for Native.

@SethTisue
Copy link
Member

agree

@ashawley ashawley mentioned this issue Jan 20, 2023
Merged
@SethTisue SethTisue mentioned this issue Jan 21, 2023
Merged
SethTisue added a commit to SethTisue/scala-xml that referenced this issue Jan 21, 2023
@SethTisue
re-enable sbt-version-policy
faae242 
fixes scala#617
SethTisue added a commit that referenced this issue Jan 23, 2023
@SethTisue
Merge pull request #641 from SethTisue/reenable-bincompat-check
3f39bdd 
fixes #617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

re-enable sbt-version-policy SethTisue/scala-xml
2 participants
@SethTisue @ashawley