Release 1.3.1

[lrytz]

We backported the stack safe Node.toString to 1.x in #684.

Publishing a patch release with that change.

[lrytz]

https://github.com/scala/scala-xml/actions/runs/5554367262/jobs/10144068126

[error] Module scala-xml has an invalid version number: 1.3.1. You must increment the minor version number to publish a source incompatible release.

[lrytz]

Not sure where to look. We have versionPolicyIntention := Compatibility.BinaryCompatible in the build (https://github.com/scala/scala-xml/blob/1.x/build.sbt#L52). I looked through https://github.com/scalacenter/sbt-version-policy and couldn't see anything obvious. cc @SethTisue

[SethTisue]

build.sbt has BinaryCompatible, so sbt-version-policy believes you ought to be releasing this as 1.4.0.

If you can change it to BinaryAndSourceCompatible and the checks pass, then it will allow you to release it as 1.3.1.

But the checks won't pass; if I set every versionPolicyIntention := Compatibility.BinaryAndSourceCompatible and then xml/versionPolicyCheck, it fails with:

[error] scala-xml: Failed binary compatibility check against org.scala-lang.modules:scala-xml_2.12:1.3.0! Found 1 potential problems
[error]  * method declaration(java.lang.String,java.lang.String,java.lang.String)Unit in class scala.xml.include.sax.XIncluder does not have a correspondent in other version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("scala.xml.include.sax.XIncluder.declaration")
[error] Module scala-xml:1.3.1 is not source compatible with version 1.3.0. You have to relax your compatibility intention by changing the value of versionPolicyIntention.

what the root cause is of the declaration difference, I don't know (didn't dig further)

[SethTisue]

btw I was extremely puzzled when I was previously in the same situation, as you'll see at scalacenter/sbt-version-policy#126 (comment). the error message could be much better

[julienrf]

Do you have suggestions for a better error message?

[lrytz]

what the root cause is of the declaration difference, I don't know (didn't dig further)

Probably a mixin forwarder due to a change in JDK > 8. The release runs on JDK 8, so should be fine.

[lrytz]

https://github.com/scala/scala-xml/actions/runs/5574179022/jobs/10182443820 went green, the releases are on maven2

[mkurz]

Thank you @lrytz!

[lrytz]

For the record, 1.3.1 was released for Scala 2.11 / 2.12 / 2.13 JVM, and for Scala 2.12 and 2.13 with Scala.js 1.

With 1.3.0, we also had releases for Scala 2.11 / 2.12 / 2.13 with Scala.js 0.6, but we excluded those here.

[SethTisue]

Do you have suggestions for a better error message?

I'll reply over at scalacenter/sbt-version-policy#126