Improve wording on stack deprecation #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the modified note in the scaladoc for these, now: |
|
Modified the note that it will "since 1.1.0" not "since 1.0.7" |
SethTisue
approved these changes
Aug 14, 2017
|
btw there are a few stray "1.0.7"s in build.sbt and shared/src/main/scala/scala/xml/XML.scala |
|
Ahhh, good catch. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A usability study of one person found that the note documenting the compatibility change in
FactoryAdapterin #150 was confusing. This is the improved wording as suggested by the same participant in the study.