Skip to content

Add tests for Utility.escape #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2018
Merged

Conversation

ashawley
Copy link
Member

@ashawley ashawley commented Apr 7, 2018

Try to improve test coverage for discussion in #203.

@ashawley ashawley force-pushed the utility-escape-test branch 2 times, most recently from e4f8631 to c629c42 Compare April 10, 2018 14:54
@ashawley ashawley force-pushed the utility-escape-test branch from c629c42 to aed4cb3 Compare April 11, 2018 13:03
@ashawley ashawley merged commit ff07a4a into scala:master Apr 11, 2018
@ashawley
Copy link
Member Author

In hindsight, it would probably be more useful to show unicode control characters on failed tests with:

def charToHex(c: Char): String = {
  "\\u%04X".format(c.toInt)
}

@ashawley ashawley deleted the utility-escape-test branch April 11, 2018 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant