Skip to content

add -Xfuture option. fix procedure syntax warnings #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2018

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Apr 9, 2018

No description provided.

@ashawley
Copy link
Member

ashawley commented Apr 9, 2018

Thanks for doing this, Kenji.

Your commit message says "add -Xfuture option." Did you forget to include a file? Maybe build.sbt?

@xuwei-k xuwei-k force-pushed the procedure-syntax branch from 4900ee4 to 3c1523b Compare April 9, 2018 12:42
@xuwei-k
Copy link
Contributor Author

xuwei-k commented Apr 9, 2018

Did you forget to include a file? Maybe build.sbt?

Oops. fixed

@ashawley ashawley added this to the 1.1.1 milestone Apr 9, 2018
@ashawley
Copy link
Member

ashawley commented Apr 9, 2018

Hey @SethTisue, is -Xfuture something we can consider enabling or does it cause a time warp in either the community build universe or compiler bootstrap? I'm thinking of a scenario where a new -Xfuture compiler error could keep the bootstrap process from working. Maybe you could think of other scenarios.

@SethTisue
Copy link
Member

I would not suggest using -Xfuture except possibly as an alternate additional testing path — not by default. It isn't something you want enabled in a release build. (Not because of bootstrapping in particular, just general concerns about quality. You want to use the best-tested version of the compiler for doing release builds of core libraries.)

-Xfuture may go away anyway in 2.13: scala/scala-dev#471

@ashawley
Copy link
Member

ashawley commented Apr 9, 2018

Ok, so -Xfuture is going away in the future. Good to know. That's not a scenario I had considered.

@ashawley
Copy link
Member

ashawley commented Apr 9, 2018

I'll merge, but undo -Xfuture and add a note per Seth's comments.

@ashawley ashawley merged commit 523e51b into scala:master Apr 9, 2018
@xuwei-k xuwei-k deleted the procedure-syntax branch May 18, 2018 02:31
@ashawley ashawley modified the milestone: 1.1.1 Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants