Skip to content

Fix deprecated ScalaInstance.libraryJar #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 26, 2019

Conversation

ashawley
Copy link
Member

Change to using xsbti.compile.ScalaInstance.libraryJars in sbt build.

[info] Loading project definition from scala-xml/project
scala-xml/build.sbt:121: warning: method libraryJar in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.
      scalaInstance.value.libraryJar
                          ^

@ashawley
Copy link
Member Author

I spent an hour trying to figure this out. Hopefully, the "corresponding Javadoc" is published somewhere for xsbti.compile.ScalaInstance? I couldn't find it. I had to just grep through GitHub repos.

@ashawley ashawley force-pushed the sbt-deprecated-scalaLibrary branch from 49078ed to a5231bb Compare December 26, 2019 18:37
Change to using xsbti.compile.ScalaInstance.libraryJars in sbt build.
@ashawley ashawley force-pushed the sbt-deprecated-scalaLibrary branch from a5231bb to 5501c95 Compare December 26, 2019 18:50
@ashawley
Copy link
Member Author

These warnings in JDK 11 and later already existed:

[warn] /home/circleci/project/shared/src/main/scala/scala/xml/package.scala:11:1: Could not find any member to link for "javax.xml.parsers.SAXParser".
[warn] /**
[warn] ^
[warn] /home/circleci/project/shared/src/main/scala/scala/xml/parsing/FactoryAdapter.scala:188:3: Could not find any member to link for "org.xml.sax.SAXException".
[warn]   /**
[warn]   ^
[warn] /home/circleci/project/shared/src/main/scala/scala/xml/include/XIncludeException.scala:13:1: Could not find any member to link for "java.lang.Throwable#getMessage".
[warn] /**
[warn] ^
[warn] /home/circleci/project/shared/src/main/scala/scala/xml/include/sax/EncodingHeuristics.scala:38:3: Could not find any member to link for "java.io.IOException".
[warn]   /**
[warn]   ^

@ashawley ashawley merged commit 31bdb3e into scala:master Dec 26, 2019
@ashawley ashawley deleted the sbt-deprecated-scalaLibrary branch December 28, 2019 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant