SI-9060: Accept fifth-edition names. #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enforce that attribute value is bounded by a quote. By the way, stop on EOF.
Valid name chars list is updated. Only 16-bit Char is supported, not arbitrary code points. Previous logic to exclude ':' as start char is deleted.
Also avoid deprecation messages and other distractions. Make sure threads are cut. (Exploring new computing metaphors.)
Closed
This was referenced Feb 12, 2016
ashawley
pushed a commit
to ashawley/scala-xml
that referenced
this pull request
Feb 15, 2016
* src/main/scala/scala/xml/parsing/TokenTests.scala (isNameChar): Add middle dot, #xB7, as specified at [4a] of XML 1.0 5th edition. * src/test/scala/scala/xml/XMLTest.scala (t9060): New test. * src/test/scala/scala/xml/parsing/ConstructingParserTest.scala (t9060): New test.
ashawley
pushed a commit
to ashawley/scala-xml
that referenced
this pull request
Feb 15, 2016
* src/main/scala/scala/xml/parsing/TokenTests.scala (isNameChar): Add middle dot, #xB7, as specified at [4a] of XML 1.0 5th edition. * src/test/scala/scala/xml/XMLTest.scala (t9060): New test. * src/test/scala/scala/xml/parsing/ConstructingParserTest.scala (t9060): New test.
ashawley
pushed a commit
to ashawley/scala-xml
that referenced
this pull request
Jun 12, 2016
* src/main/scala/scala/xml/parsing/TokenTests.scala (isNameChar): Add middle dot, #xB7, as specified at [4a] of XML 1.0 5th edition. * src/test/scala/scala/xml/XMLTest.scala (t9060): New test. * src/test/scala/scala/xml/parsing/ConstructingParserTest.scala (t9060): New test.
ashawley
pushed a commit
to ashawley/scala-xml
that referenced
this pull request
Sep 14, 2016
* src/main/scala/scala/xml/parsing/TokenTests.scala (isNameChar): Add middle dot, #xB7, as specified at [4a] of XML 1.0 5th edition. * src/test/scala/scala/xml/XMLTest.scala (t9060): New test. * src/test/scala/scala/xml/parsing/ConstructingParserTest.scala (t9060): New test.
ashawley
pushed a commit
to ashawley/scala-xml
that referenced
this pull request
Sep 20, 2016
* src/main/scala/scala/xml/parsing/TokenTests.scala (isNameChar): Add middle dot, #xB7, as specified at [4a] of XML 1.0 5th edition. * src/test/scala/scala/xml/XMLTest.scala (t9060): New test. * src/test/scala/scala/xml/parsing/ConstructingParserTest.scala (t9060): New test.
ashawley
pushed a commit
to ashawley/scala-xml
that referenced
this pull request
Oct 18, 2016
* src/main/scala/scala/xml/parsing/TokenTests.scala (isNameChar): Add middle dot, #xB7, as specified at [4a] of XML 1.0 5th edition. * src/test/scala/scala/xml/XMLTest.scala (t9060): New test. * src/test/scala/scala/xml/parsing/ConstructingParserTest.scala (t9060): New test.
ashawley
pushed a commit
to ashawley/scala-xml
that referenced
this pull request
Dec 1, 2016
* src/main/scala/scala/xml/parsing/TokenTests.scala (isNameChar): Add middle dot, #xB7, as specified at [4a] of XML 1.0 5th edition. * src/test/scala/scala/xml/XMLTest.scala (t9060): New test. * src/test/scala/scala/xml/parsing/ConstructingParserTest.scala (t9060): New test.
|
@som-snytt needs rebase. as you've probably seen already, I'm doing a sweep over this repos open PRs, trying to ascertain their status and seeing if there's anything that can be merged. is this PR still relevant, and would you be interested in getting it over the finish line? |
|
The conflicts are trivial -- git is amazing -- but are the maintainers going to merge it or what? I haven't used xml in a decade. Do they care? |
ashawley
pushed a commit
to ashawley/scala-xml
that referenced
this pull request
Feb 4, 2017
* src/main/scala/scala/xml/parsing/TokenTests.scala (isNameChar): Add middle dot, #xB7, as specified at [4a] of XML 1.0 5th edition. * src/test/scala/scala/xml/XMLTest.scala (t9060): New test. * src/test/scala/scala/xml/parsing/ConstructingParserTest.scala (t9060): New test.
ashawley
pushed a commit
to ashawley/scala-xml
that referenced
this pull request
Feb 4, 2017
* src/main/scala/scala/xml/parsing/TokenTests.scala (isNameChar): Add middle dot, #xB7, as specified at [4a] of XML 1.0 5th edition. * src/test/scala/scala/xml/XMLTest.scala (t9060): New test. * src/test/scala/scala/xml/parsing/ConstructingParserTest.scala (t9060): New test.
ashawley
pushed a commit
to ashawley/scala-xml
that referenced
this pull request
Feb 5, 2017
* jvm/src/main/scala/scala/xml/parsing/TokenTests.scala (isNameChar): Add middle dot, #xB7, as specified at [4a] of XML 1.0 5th edition. * jvm/src/test/scala/scala/xml/XMLTest.scala (t9060): New test. * jvm/src/test/scala/scala/xml/parsing/ConstructingParserTest.scala (t9060): New test.
ashawley
pushed a commit
to ashawley/scala-xml
that referenced
this pull request
Feb 7, 2017
* jvm/src/main/scala/scala/xml/parsing/TokenTests.scala (isNameChar): Add middle dot, #xB7, as specified at [4a] of XML 1.0 5th edition. * jvm/src/test/scala/scala/xml/XMLTest.scala (t9060): New test. * jvm/src/test/scala/scala/xml/parsing/ConstructingParserTest.scala (t9060): New test.
if you rebase it, I will personally make sure it gets merged (if no one raises substantive objections) |
|
oh, you know what? actually, never mind, let's go with #44 instead, sorry for missing that before. |
ashawley
pushed a commit
to ashawley/scala-xml
that referenced
this pull request
Feb 15, 2017
* jvm/src/main/scala/scala/xml/parsing/TokenTests.scala (isNameChar): Add middle dot, #xB7, as specified at [4a] of XML 1.0 5th edition. * jvm/src/test/scala/scala/xml/XMLTest.scala (t9060): New test. * jvm/src/test/scala/scala/xml/parsing/ConstructingParserTest.scala (t9060): New test.
This was referenced Apr 7, 2017
ashawley
pushed a commit
to ashawley/scala-xml
that referenced
this pull request
Apr 25, 2017
* jvm/src/main/scala/scala/xml/parsing/TokenTests.scala (isNameChar): Add middle dot, #xB7, as specified at [4a] of XML 1.0 5th edition. * jvm/src/test/scala/scala/xml/XMLTest.scala (t9060): New test. * jvm/src/test/scala/scala/xml/parsing/ConstructingParserTest.scala (t9060): New test.
ashawley
pushed a commit
to ashawley/scala-xml
that referenced
this pull request
Apr 26, 2017
* jvm/src/main/scala/scala/xml/parsing/TokenTests.scala (isNameChar): Add middle dot, #xB7, as specified at [4a] of XML 1.0 5th edition. * jvm/src/test/scala/scala/xml/XMLTest.scala (t9060): New test. * jvm/src/test/scala/scala/xml/parsing/ConstructingParserTest.scala (t9060): New test.
ashawley
pushed a commit
to ashawley/scala-xml
that referenced
this pull request
Apr 26, 2017
* jvm/src/main/scala/scala/xml/parsing/TokenTests.scala (isNameChar): Add middle dot, #xB7, as specified at [4a] of XML 1.0 5th edition. * jvm/src/test/scala/scala/xml/XMLTest.scala (t9060): New test. * jvm/src/test/scala/scala/xml/parsing/ConstructingParserTest.scala (t9060): New test.
ashawley
pushed a commit
to ashawley/scala-xml
that referenced
this pull request
Apr 28, 2017
* jvm/src/main/scala/scala/xml/parsing/TokenTests.scala (isNameChar): Add middle dot, #xB7, as specified at [4a] of XML 1.0 5th edition. * jvm/src/test/scala/scala/xml/XMLTest.scala (t9060): New test. * jvm/src/test/scala/scala/xml/parsing/ConstructingParserTest.scala (t9060): New test.
ashawley
pushed a commit
to ashawley/scala-xml
that referenced
this pull request
Apr 28, 2017
* jvm/src/main/scala/scala/xml/parsing/TokenTests.scala (isNameChar): Add middle dot, #xB7, as specified at [4a] of XML 1.0 5th edition. * jvm/src/test/scala/scala/xml/XMLTest.scala (t9060): New test. * jvm/src/test/scala/scala/xml/parsing/ConstructingParserTest.scala (t9060): New test.
ashawley
pushed a commit
to ashawley/scala-xml
that referenced
this pull request
May 5, 2017
* jvm/src/main/scala/scala/xml/parsing/TokenTests.scala (isNameChar): Add middle dot, #xB7, as specified at [4a] of XML 1.0 5th edition. * jvm/src/test/scala/scala/xml/XMLTest.scala (t9060): New test. * jvm/src/test/scala/scala/xml/parsing/ConstructingParserTest.scala (t9060): New test.
ashawley
pushed a commit
to ashawley/scala-xml
that referenced
this pull request
May 5, 2017
* jvm/src/main/scala/scala/xml/parsing/TokenTests.scala (isNameChar): Add middle dot, #xB7, as specified at [4a] of XML 1.0 5th edition. * jvm/src/test/scala/scala/xml/XMLTest.scala (t9060): New test. * jvm/src/test/scala/scala/xml/parsing/ConstructingParserTest.scala (t9060): New test.
ashawley
pushed a commit
to ashawley/scala-xml
that referenced
this pull request
May 6, 2017
* jvm/src/main/scala/scala/xml/parsing/TokenTests.scala (isNameChar): Add middle dot, #xB7, as specified at [4a] of XML 1.0 5th edition. * jvm/src/test/scala/scala/xml/XMLTest.scala (t9060): New test. * jvm/src/test/scala/scala/xml/parsing/ConstructingParserTest.scala (t9060): New test.
ashawley
pushed a commit
to ashawley/scala-xml
that referenced
this pull request
May 12, 2017
* jvm/src/main/scala/scala/xml/parsing/TokenTests.scala (isNameChar): Add middle dot, #xB7, as specified at [4a] of XML 1.0 5th edition. * jvm/src/test/scala/scala/xml/XMLTest.scala (t9060): New test. * jvm/src/test/scala/scala/xml/parsing/ConstructingParserTest.scala (t9060): New test.
ashawley
pushed a commit
to ashawley/scala-xml
that referenced
this pull request
May 24, 2017
* jvm/src/main/scala/scala/xml/parsing/TokenTests.scala (isNameChar): Add middle dot, #xB7, as specified at [4a] of XML 1.0 5th edition. * jvm/src/test/scala/scala/xml/XMLTest.scala (t9060): New test. * jvm/src/test/scala/scala/xml/parsing/ConstructingParserTest.scala (t9060): New test.
ashawley
pushed a commit
to ashawley/scala-xml
that referenced
this pull request
May 24, 2017
* jvm/src/main/scala/scala/xml/parsing/TokenTests.scala (isNameChar): Add middle dot, #xB7, as specified at [4a] of XML 1.0 5th edition. * jvm/src/test/scala/scala/xml/XMLTest.scala (t9060): New test. * jvm/src/test/scala/scala/xml/parsing/ConstructingParserTest.scala (t9060): New test.
ashawley
added a commit
that referenced
this pull request
May 24, 2017
Fix #44 SI-9060 XML 5th edition name characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accept fifth-edition names.
Fix infinite loopiness in attribute parsing.
Improve tests a bit.