Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle XML namespace declarations even when the underlying parser is … #587

Merged
merged 1 commit into from
Feb 20, 2022
Merged

Handle XML namespace declarations even when the underlying parser is … #587

merged 1 commit into from
Feb 20, 2022

Conversation

dubinsky
Copy link
Contributor

@dubinsky dubinsky commented Jan 7, 2022

…namespace-aware.

fixes #506

@dubinsky dubinsky marked this pull request as ready for review January 7, 2022 05:06
@dubinsky
Copy link
Contributor Author

dubinsky commented Jan 7, 2022

@ashawley @SethTisue could you please take a look? thanks!

@dubinsky
Copy link
Contributor Author

@ashawley @SethTisue Is there anything I need to change in this pull request for it to get merged? Thanks!

@SethTisue
Copy link
Member

I know next to nothing about this codebase, so I'm unable to offer substantive review here.

Let's give Aaron a little more time, like a week or so, and if he doesn't turn up, I'd be happy to optimistically merge it, since you seem to be about as expert on this stuff as anybody.

@dubinsky
Copy link
Contributor Author

Let's give Aaron a little more time, like a week or so, and if he doesn't turn up, I'd be happy to optimistically merge it, since you seem to be about as expert on this stuff as anybody.

You are too kind! I'll wait. I won't be able to use the new functionality anyway until it is released, and Aron wanted to follow up on my previous pull request with few amendments to the API choices in this around naming...

@dubinsky
Copy link
Contributor Author

@ashawley @SethTisue Is there anything I need to change in this pull request for it to get merged? Thanks!

@SethTisue SethTisue merged commit 7c01069 into scala:main Feb 20, 2022
@SethTisue SethTisue mentioned this pull request Mar 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not assume that parser is namespace-unaware
2 participants
@dubinsky @SethTisue