Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup #654

Merged
merged 1 commit into from
Mar 28, 2023
Merged

cleanup #654

merged 1 commit into from
Mar 28, 2023

Conversation

dubinsky
Copy link
Contributor

@dubinsky dubinsky commented Mar 26, 2023 •
edited
Loading

  • fix some dangling ScalaDoc references
  • drop () after toString and a few other methods
  • replace unused pattern variables with _
  • remove code duplication in name-splitting

I split the code cleanup part out of the #649 so that we can get it out of the way and concentrate on the type-tightening and binary compatibility...

@dubinsky dubinsky marked this pull request as ready for review March 26, 2023 19:19
@dubinsky dubinsky requested a review from SethTisue March 26, 2023 19:19
@SethTisue SethTisue mentioned this pull request Mar 27, 2023
Closed
@dubinsky
cleanup
16374df 
- fix some dangling ScalaDoc references
- drop `()` after `toString` and a few other methods
- replace unused pattern variables with `_`
- remove code duplication in name-splitting
@dubinsky dubinsky merged commit cf5763e into scala:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethTisue SethTisue SethTisue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dubinsky @SethTisue