Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XMLLoader returns Document #663

Merged
merged 1 commit into from
Jun 7, 2023
Merged

XMLLoader returns Document #663

merged 1 commit into from
Jun 7, 2023

Conversation

dubinsky
Copy link
Contributor

@dubinsky dubinsky commented May 22, 2023

  • moved private def parse() from XMLLoader to FactoryAdapter;
  • FactoryAdapter.parse returns Document;
  • added yet another flavor of the XMLLoader.load* methods returning Document: load*Document;
  • expressed all the other load methods in terms of the load*Document;

@dubinsky dubinsky marked this pull request as draft May 22, 2023 01:23
@dubinsky
Copy link
Contributor Author

@SethTisue @ashawley a small step towards parity between XMLLoader and MarkupParser...

@dubinsky dubinsky marked this pull request as ready for review May 25, 2023 01:26
- `FactoryAdapter.parse` returns `Document`;
- added yet another flavor of the `XMLLoader.load*` methods returning `Document`: `load*Document`;
- expressed all the other `load` methods in terms of the `load*Document`;
@dubinsky dubinsky merged commit 5d1991f into scala:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant