Skip to content

Added all missing type annotations. #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2023
Merged

Added all missing type annotations. #675

merged 1 commit into from
Jun 20, 2023

Conversation

dubinsky
Copy link
Contributor

  • introduced ScalaVersionSpecificReturnTypes;
  • split MIMA exclusions by Scala version;
  • removed exclusions that are no longer needed;
  • made Circle CI task names not mention the exact Scala version;
  • provisioned for Scala 2.13-specific code;
  • Scala 2.13- is only Scala 2.12 now that Scala 11 is no longer supported :)
  • marked classes used by the compiler.

@dubinsky
Added all missing type annotations.
3742370 
- introduced `ScalaVersionSpecificReturnTypes`;
- split MIMA exclusions by Scala version;
- removed exclusions that are no longer needed;
- made Circle CI task names not mention the exact Scala version;
- provisioned for Scala 2.13-specific code;
- Scala 2.13- is only Scala 2.12 now that Scala 11 is no longer supported :)
- marked classes used by the compiler.
@dubinsky dubinsky marked this pull request as ready for review June 20, 2023 04:45
@dubinsky dubinsky mentioned this pull request Jun 20, 2023
Closed
@dubinsky dubinsky requested review from lrytz, SethTisue and ashawley June 20, 2023 04:48
lrytz
lrytz approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @dubinsky!

I'll let @SethTisue also take a look.

SethTisue
SethTisue approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@dubinsky
Copy link
Contributor Author

Thank you, merging!

@dubinsky dubinsky merged commit 9f5425f into scala:main Jun 20, 2023
@lrytz lrytz mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrytz lrytz lrytz approved these changes

@SethTisue SethTisue SethTisue approved these changes

@ashawley ashawley Awaiting requested review from ashawley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dubinsky @lrytz @SethTisue