Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equality cleanup: #678

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Equality cleanup: #678

merged 1 commit into from
Jun 30, 2023

Conversation

dubinsky
Copy link
Contributor

@dubinsky dubinsky commented Jun 22, 2023

  • replaced all a.equals(b) with a == b;
  • replaced all a.eq(null) with a == null;
  • replaced all a.ne(null) with a != null;
  • replaced all a.eq(Null) with a.isNull;
  • replaced some string == "" with string.isEmpty;
  • removed some spurious braces.

@dubinsky dubinsky marked this pull request as ready for review June 23, 2023 00:21
@dubinsky
Copy link
Contributor Author

This is likely to be the last pull request before the release :)

- replaced all `a.equals(b)` with `a == b`;
- replaced all `a.eq(null)` with `a == null`;
- replaced all `a.ne(null)` with `a != null`;
- replaced all `a.eq(Null) with `a.isNull`;
- replaced some `string == ""` with `string.isEmpty`;
- removed some spurious braces.
Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dubinsky
Copy link
Contributor Author

Thank you @lrytz!

@lrytz lrytz merged commit 098911b into scala:main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants