Remove final keyword from scala.xml.MetaData per note #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure when the experimental option was dropped from the compile options. Couldn't trace back in the current build.sbt history. Looks like it predates to xml as part of the core. Compiling fine. Looks good to me. |
biswanaths
added a commit
that referenced
this pull request
Oct 3, 2015
Remove final keyword from scala.xml.MetaData per note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-Xexperimentalcompiler options is not enabled in the project's SBT file, so presumably, this line isn't needed anymore per the comment in the code.I added
-XexperimentaltoscalacOptionand didn't have a problem compiling in either 2.12.0.M2 and 2.11.7.