Skip to content

fix t9400 test with JDK9+ #7288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2018
Merged

fix t9400 test with JDK9+ #7288

merged 1 commit into from
Oct 1, 2018

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Sep 30, 2018

t9400.scala:2: error: class Deprecation needs to be abstract, since:
it has 2 unimplemented members.
/** As seen from class Deprecation, the missing signatures are as follows.
 *  For convenience, these are usable as stub implementations.
 */
  def forRemoval(): Boolean = ???
  def since(): String = ???

class Deprecation extends Deprecated {
      ^
one error found

@scala-jenkins scala-jenkins added this to the 2.13.0-RC1 milestone Sep 30, 2018
@xuwei-k xuwei-k mentioned this pull request Sep 30, 2018
3 tasks
@xuwei-k
Copy link
Contributor Author

xuwei-k commented Sep 30, 2018

https://scala-ci.typesafe.com/job/scala-2.13.x-validate-main/4889/testReport/junit/scala.collection.immutable/ImmutableChampHashMapProperties/merged_right____select_left___is_the_same_as_right_concat_left/

#7254 😕 /cc @joshlemer

sbt.ForkMain$ForkError: java.lang.Exception: Falsified after 1 passed tests.
> ARG_0: HashMap( -> )
> ARG_1: HashMap( -> )
> ARG_1_ORIGINAL: HashMap( -> 㡑)
	at org.scalacheck.CustomScalaCheckRunner$$anon$2$$anon$3.<init>(CustomScalaCheckRunner.scala:126)
	at org.scalacheck.CustomScalaCheckRunner$$anon$2.executeInternal(CustomScalaCheckRunner.scala:115)
	at org.scalacheck.CustomScalaCheckRunner$$anon$2.$anonfun$execute$10(CustomScalaCheckRunner.scala:105)
	at org.scalacheck.CustomScalaCheckRunner$$anon$2.$anonfun$execute$10$adapted(CustomScalaCheckRunner.scala:104)
	at scala.collection.IterableOnceOps.foreach(IterableOnce.scala:451)
	at scala.collection.IterableOnceOps.foreach$(IterableOnce.scala:449)
	at scala.collection.AbstractIterable.foreach(Iterable.scala:898)
	at scala.collection.IterableOps$WithFilter.foreach(Iterable.scala:867)
	at org.scalacheck.CustomScalaCheckRunner$$anon$2.execute(CustomScalaCheckRunner.scala:104)
	at sbt.ForkMain$Run.lambda$runTest$1(ForkMain.java:304)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

@joshlemer
Copy link
Contributor

Sorry! Looking into it

@joshlemer
Copy link
Contributor

joshlemer commented Sep 30, 2018

This should be fixed in #7289

As a side note, maybe the property tests should be pinned to a seed, so that they are deterministic?

@xuwei-k
Copy link
Contributor Author

xuwei-k commented Oct 1, 2018

```
t9400.scala:2: error: class Deprecation needs to be abstract, since:
it has 2 unimplemented members.
/** As seen from class Deprecation, the missing signatures are as follows.
 *  For convenience, these are usable as stub implementations.
 */
  def forRemoval(): Boolean = ???
  def since(): String = ???

class Deprecation extends Deprecated {
      ^
one error found
```
@xuwei-k
Copy link
Contributor Author

xuwei-k commented Oct 1, 2018

rebased

@lrytz lrytz merged commit 61f9064 into scala:2.13.x Oct 1, 2018
@xuwei-k xuwei-k deleted the t9400-jdk9 branch October 1, 2018 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants