Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[after #9141] growing builder #9094

Closed
wants to merge 1 commit into from
Closed

[after #9141] growing builder #9094

wants to merge 1 commit into from

Conversation

mkeskells
Copy link
Contributor

add ++= to GrowingBuilder, to allow mutable implementations to optimise bulk addition

@scala-jenkins scala-jenkins added this to the 2.12.13 milestone Jun 30, 2020
@mkeskells mkeskells force-pushed the 2.12.x_growing_builder branch from c94d7e9 to 5fd3b6b Compare June 30, 2020 08:27
@mkeskells mkeskells force-pushed the 2.12.x_growing_builder branch from 5fd3b6b to ae946c1 Compare July 2, 2020 13:07
@mkeskells
Copy link
Contributor Author

Mima issue -

method ++=(scala.collection.TraversableOnce)scala.collection.mutable.GrowingBuilder in class scala.collection.mutable.GrowingBuilder does not have a correspondent in other version

@mkeskells

This comment has been minimized.

Sign in to view
@diesalbla diesalbla added the library:collections PRs involving changes to the standard collection library label Jul 3, 2020
@mkeskells mkeskells requested a review from dwijnand August 2, 2020 15:22
@dwijnand
Copy link
Member

dwijnand commented Aug 3, 2020

Yeah, that's our darned forward-compatibility guarantee. I guess we can safely land this if/once #9141 lands.

The fix to clear can land sooner than that, if you'd like.

@mkeskells mkeskells changed the title growing builder [after #9141] growing builder Aug 3, 2020
@mkeskells mkeskells marked this pull request as draft August 3, 2020 09:02
@mkeskells
Copy link
Contributor Author

Yeah, that's our darned forward-compatibility guarantee. I guess we can safely land this if/once #9141 lands.

The fix to clear can land sooner than that, if you'd like.

made it draft until #9141 is merged

@dwijnand dwijnand modified the milestones: 2.12.13, 2.12.14 Oct 16, 2020
@dwijnand
Copy link
Member

dwijnand commented Dec 4, 2020

Going to add this to the list in scala/bug#11804 (comment), and otherwise close this one as we cannot land it without that.

@dwijnand dwijnand closed this Dec 4, 2020
@dwijnand dwijnand mentioned this pull request Dec 4, 2020
Closed
@SethTisue SethTisue removed this from the 2.12.14 milestone Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand Awaiting requested review from dwijnand

Assignees
No one assigned
Labels
library:collections PRs involving changes to the standard collection library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mkeskells @dwijnand @SethTisue @scala-jenkins @diesalbla