Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[after #9141] optimised ListMap.head #9266

Closed
wants to merge 1 commit into from
Closed

[after #9141] optimised ListMap.head #9266

wants to merge 1 commit into from

Conversation

mkeskells
Copy link
Contributor

@mkeskells mkeskells commented Oct 22, 2020 •
edited
Loading

Addressing the head part of scala/bug#11752

Mima issue


[error] scala-library: Failed binary compatibility check against org.scala-lang:scala-library:2.12.0! Found 1 potential problems (filtered 858)
[error]  * method head()scala.Tuple2 in class scala.collection.immutable.ListMap does not have a correspondent in other version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("scala.collection.immutable.ListMap.head")

@lrytz is this a candidate for #9141?

@scala-jenkins scala-jenkins added this to the 2.12.13 milestone Oct 22, 2020
@SethTisue SethTisue added library:collections PRs involving changes to the standard collection library performance the need for speed. usually compiler performance, sometimes runtime performance. labels Oct 22, 2020
@mkeskells mkeskells mentioned this pull request Oct 22, 2020
Closed
@mkeskells mkeskells marked this pull request as draft October 27, 2020 07:30
@mkeskells mkeskells changed the title optimised ListMap.head [after #9141] optimised ListMap.head Oct 27, 2020
@lrytz
Copy link
Member

lrytz commented Oct 27, 2020

@lrytz is this a candidate for #9141?

yes

@retronym retronym modified the milestones: 2.12.13, 2.12.14 Nov 23, 2020
@dwijnand
Copy link
Member

dwijnand commented Dec 4, 2020

Going to add this to the list in scala/bug#11804 (comment), and otherwise close this one as we cannot land it without that.

@dwijnand dwijnand closed this Dec 4, 2020
@dwijnand dwijnand mentioned this pull request Dec 4, 2020
Closed
@SethTisue SethTisue removed this from the 2.12.14 milestone Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
library:collections PRs involving changes to the standard collection library performance the need for speed. usually compiler performance, sometimes runtime performance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mkeskells @lrytz @dwijnand @retronym @SethTisue @scala-jenkins