Skip to content

Backport "fix: Only fallback to the definition of a synthetic valdef if it is zero extent" to 3.3 LTS #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

Backport "fix: Only fallback to the definition of a synthetic valdef if it is zero extent" to 3.3 LTS #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions presentation-compiler/src/main/dotty/tools/pc/completions/CompletionProvider.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,9 @@ class CompletionProvider(
* 4| $1$.sliding@@[Int](size, step)
*
*/
if qual.symbol.is(Flags.Synthetic) && qual.symbol.name.isInstanceOf[DerivedName] =>
if qual.symbol.is(Flags.Synthetic) && qual.span.isZeroExtent && qual.symbol.name.isInstanceOf[DerivedName] =>
qual.symbol.defTree match
case valdef: ValDef => Select(valdef.rhs, name) :: tail
case valdef: ValDef if !valdef.rhs.isEmpty => Select(valdef.rhs, name) :: tail
case _ => tpdPath0
case _ => tpdPath0

Expand Down
11 changes: 11 additions & 0 deletions presentation-compiler/test/dotty/tools/pc/tests/completion/CompletionSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2134,3 +2134,14 @@ class CompletionSuite extends BaseCompletionSuite:
"""|build: Unit
|""".stripMargin,
)

@Test def i7191 =
check(
"""|val x = Some(3).map(_.@@)
|""".stripMargin,
"""|!=(x: Byte): Boolean
|!=(x: Char): Boolean
|!=(x: Double): Boolean
|""".stripMargin,
topLines = Some(3)
)