Skip to content

Backport "Rename on import is never wildcard" to 3.3 LTS #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025
Merged

Backport "Rename on import is never wildcard" to 3.3 LTS #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86169a8
Rename on import is never wildcard
som-snytt Mar 5, 2025
fdf7cdc
bugfix: Adjust givens to old syntax
tgodzik Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion compiler/src/dotty/tools/dotc/transform/CheckUnused.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,11 @@ class CheckUnused private (phaseMode: PhaseMode, suffix: String) extends MiniPha
case sel :: sels =>
val matches =
if sel.isWildcard then
// if name is different from sym.name, it must be a rename on import, not a wildcard selector
!name.exists(_.toTermName != sym.name.toTermName)
// the qualifier must have the target symbol as a member
hasAltMember(sym.name) && {
&& hasAltMember(sym.name)
&& {
if sel.isGiven then // Further check that the symbol is a given or implicit and conforms to the bound
sym.isOneOf(GivenOrImplicit)
&& (sel.bound.isEmpty || sym.info.finalResultType <:< sel.boundTpe)
Expand Down
7 changes: 7 additions & 0 deletions tests/warn/i15503a.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,3 +321,10 @@ object Suppressed:
object Suppressing:
import Suppressed.* // no warn, see options
def f = 42

package i22692:
import javax.swing.*
import javax.swing.event as swingEvent // no warn, regression test for warning in 3.6

type b = AbstractButton
type t = swingEvent.AncestorListener
6 changes: 3 additions & 3 deletions tests/warn/i15503f.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@ package givens:
trait Y:
def doY: String

given X:
given X with
def doX = 7

given X => Y: // warn protected param to given class
given (using X): Y with // warn protected param to given class
def doY = "7"
/* desugared. It is protected so that its type can be used in member defs without leaking.
* possibly it should be protected only for named parameters.
Expand All @@ -72,6 +72,6 @@ package givens:
new givens.given_Y(using x$1)()
*/

given namely: (x: X) => Y: // warn protected param to given class
given namely (using x: X): Y with // warn protected param to given class
def doY = "8"
end givens
Loading