Backport "-Yprofile-trace properly report macro splicing source" to 3.3 LTS #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when we had some code like: def userCode: Unit = ... val x = myExpensiveMacro() ... The profiler reported the time spent executing the macro as `«method userCode»` which is misleading. This commit changes it to be reported as `«method myExpensiveMacro»`. This is particularly useful in bottom-up profiling to find which macros we spend the most amount of time in. [Cherry-picked 7f81cc5]
|
No regressions detected in the community build up to backport-lts-3.3-23488. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports scala#23488 to the 3.3.7.
PR submitted by the release tooling.