Skip to content

Backport "Avoid erasure/preErasure issues around Any in transformIsInstanceOf" to 3.3 LTS #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Backport "Avoid erasure/preErasure issues around Any in transformIsInstanceOf" to 3.3 LTS #66

wants to merge 3 commits into from

Conversation

tgodzik
Copy link

@tgodzik tgodzik commented Feb 14, 2025

Backports scala#21647 to the 3.3.6.

PR submitted by the release tooling.
[skip ci]

@dwijnand @tgodzik
Avoid erasure/preErasure issues around Any in transformIsInstanceOf
7458941 
The testType Any is erased to Object, but the expr type Int isn't erased
to Integer, so then it fails as Int !<: Object.  We avoid the problem by
feeding in AnyVal, leading to a (possibly elided) non-null test only.

[Cherry-picked d02d4b8]
@dwijnand @tgodzik
Simplify transformIsInstanceOf check
e463cce 
[Cherry-picked 7b721f0]
@dwijnand @tgodzik
Add extra isInstanceOf test cases
f7a54b0 
[Cherry-picked 49d876a]
@tgodzik tgodzik closed this Feb 14, 2025
@tgodzik tgodzik deleted the backport-lts-3.3-21647 branch February 14, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgodzik @dwijnand