Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcelinks tests does not consider src-bootstrapped #13404

Open
odersky opened this issue Aug 27, 2021 · 3 comments
Open

Sourcelinks tests does not consider src-bootstrapped #13404

odersky opened this issue Aug 27, 2021 · 3 comments

Comments

@odersky
Copy link
Contributor

odersky commented Aug 27, 2021

#11721 fails with the stdlib-sourcelinks-test. it complains that library/src/scala/CanThrow.scala does not exist. That's because it is in src-bootstrapped, not src.

Expectation

stdlib-sourcelinks-test should also consider sources in src-bootstrapped.

This is a blocker for 3.1.

@odersky odersky added this to the 3.1.0 milestone Aug 27, 2021
@pikinier20
Copy link
Contributor

pikinier20 commented Aug 27, 2021

I'm going to create PR with workaround for #11721 but in general the problem remains and should be fixed

EDIT: Actually, I realized that it's not a problem with source links test but with source links generation because it always assumes that file is under src directory

@pikinier20
Copy link
Contributor

I think we can drop it from 3.1.0 as it's not a blocker anymore

@pikinier20 pikinier20 removed this from the 3.1.0 milestone Aug 27, 2021
@odersky
Copy link
Contributor Author

odersky commented Sep 1, 2021

It's a blocker for any work that creates a file in bootstrapped. So we should still fix it ASAP. In my experience sourceLinks fails more often than any other test. Given how relatively little the test actually checks, that must count as one of the biggest productivity blockers we have today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants