Skip to content

Nightly Dotty workflow of 2022-05-21 failed #15257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions bot opened this issue May 21, 2022 · 3 comments · Fixed by #15259
Closed

Nightly Dotty workflow of 2022-05-21 failed #15257

github-actions bot opened this issue May 21, 2022 · 3 comments · Fixed by #15259

Comments

@github-actions
Copy link
Contributor

See https://github.com/lampepfl/dotty/actions/runs/2361734322

@bishabosha
Copy link
Member

Failed due to #15241

Looks like the current windows environment does not support -S flag for the env tool, but @philwalk says it should be available in a more recent version

@philwalk
Copy link
Contributor

philwalk commented May 21, 2022

The installed coreutils version can be displayed via:

$ cygcheck -f /usr/bin/env

The current default version installed by the cygwin installer is: coreutils-8.26-2.

The -S flag is not supported on cygwin earlier than version coreutils-8.32-1.
Because it's not the default version, it must be explicitly selected.
It shows up as version 8.32-1-TEST in the pull-down menu of the installer on my system.

Perhaps we need two versions of each of the affected test scripts, one for macos, the other for everything else.

The relevant change in BashScriptsTests.scala lines 199-200 might be:

197   @Test def sqlDateTest =
198     val scriptBase = "sqlDateError"
199     val scriptFilename = if (ostype == "darwin") s"$scriptBase-darwin.sc" else s"$scriptBase.sc"
200     val scriptFile = testFiles.find(_.getName == scriptFilename).get

@philwalk
Copy link
Contributor

The problem on macos that this change was intended to fix, if I understand it correctly, is due to the fact that osx doesn't allow hashbang lines to call scripts, but only supports referencing a binary executable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants