BashScriptTests: shebang lines work on macos #15241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
changed the title
philwalk
approved these changes
May 20, 2022
There was a problem hiding this comment.
The -S option requires a recent version of /usr/bin/env which is not universally available.
But it does solve the problem on macos, so perhaps it's not so hard to find workarounds for other environments. In order to build in Windows/cygwin, there is now a coreutils version 8.32-1 that should solve the problem.
WRT the import change, I think the only requirement is that it should fail to compile if the hashbang line fails to set an extended classpath, so that looks good.
|
LGTM |
This was referenced May 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
usr/bin/envto run scala command (sometimes with-S)update
import jline.terminal.Terminaltoimport jsoup.Jsoup, this is because jline was already part of the classpath (added by thedist/bin/commonscript).I hope that this is still testing the bug with globbing arguments on jvm on windows.