Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc.: Scala 3 Reference pages hide scrollbars #17046

Closed
dsbos opened this issue Mar 5, 2023 · 5 comments · Fixed by #17203
Closed

Doc.: Scala 3 Reference pages hide scrollbars #17046

dsbos opened this issue Mar 5, 2023 · 5 comments · Fixed by #17203

Comments

@dsbos
Copy link

dsbos commented Mar 5, 2023

Compiler version

N/A

Minimized example

Browse to page at https://docs.scala-lang.org/scala3/reference/syntax.html

Output

Page displays with no vertical scrollbar.

Expectation

Since, obviously, the page is longer (vertically) than a browser display pane, I expected the page to show up with a vertical scrollbar.

However, no vertical scrollbar appears, meaning that the user:

  • can't see how far down in the page he or she is (i.e., there is no scrollbar slider indicating the position), and
  • doesn't have a place to click to scroll down (or up) by one page (browser display pane height)

(Yes, users with pointing devices that scroll directly can move the page, but they can't easily jump down one screen-full (well, pane-full), and they can't see how far down in the page they are. (And any user with a non-scrollwheel mouse or a limited trackpad/etc. wouldn't be able to scroll at all without the keyboard.))

Apparently, your HTML/CSS for Scala 3 Reference pages suppresses scrollbars (well, at least in Chrome and Firefox; things still work in SeaMonkey).

Scala 3 Reference authors: Don't force your scrollbar preferences on all readers. (If you don't want to see vertical scrollbars, configure your browser(s), window manager, and/or operating system to suppress scrollbars; don't suppress them in the HTML/CSS for all readers.)

@dsbos dsbos added the stat:needs triage Every issue needs to have an "area" and "itype" label label Mar 5, 2023
@szymon-rd szymon-rd added area:doctool itype:enhancement and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Mar 6, 2023
@szymon-rd
Copy link
Contributor

Thank you for reporting!

@Dedelweiss
Copy link
Contributor

Dedelweiss commented Apr 3, 2023

I tried a first correction. I haven't done a PR yet as I'm not sure of the outcome but would that be what you're asking?
Screenshot 2023-04-03 at 15 28 09

Screenshot 2023-04-03 at 15 33 41

@szymon-rd
Copy link
Contributor

Hi! Thanks for your work, but in the end, we thought that for the article's body, the ToC is the de facto replacement of the scrollbar. There possibly could be some small and non-invasive scrollbar in the navigation.

@Dedelweiss
Copy link
Contributor

Okay sure ! So I keep the body scroll bar but more discreet as below? Or only for the sidebar on the left?
Screenshot 2023-04-03 at 16 38 00
Screenshot 2023-04-03 at 16 40 58
Screenshot 2023-04-03 at 16 38 46

@szymon-rd
Copy link
Contributor

I think it'd be better to keep only the one on the left for navigation and rely on ToC for the right pane. Great work on the styling! Could you check if it works ok after going to a different page, opening a page from a link (if it's in the correct position afterwards, not on the top when the content is already scrolled), etc.?

szymon-rd added a commit that referenced this issue Apr 24, 2023
## Chrome(White mode): 
<img width="1648" alt="Screenshot 2023-04-04 at 10 35 44"
src="https://user-images.githubusercontent.com/44496264/229736193-76c103af-a6a9-463e-968c-f3bd7e84543f.png">

## Chrome(Dark mode): 
<img width="1648" alt="Screenshot 2023-04-04 at 10 35 50"
src="https://user-images.githubusercontent.com/44496264/229736266-568a4650-f054-42ad-bdaf-44ee3f26d40c.png">

## Safari:
<img width="1648" alt="Screenshot 2023-04-04 at 10 35 35"
src="https://user-images.githubusercontent.com/44496264/229736413-ca354f8f-ede4-4f99-8ff8-e1efcd6fa468.png">

## Mozilla:
<img width="1648" alt="Screenshot 2023-04-04 at 10 35 16"
src="https://user-images.githubusercontent.com/44496264/229736453-917edc61-0ae3-4cff-9dcb-33a4d200f6bf.png">

Fixes: #17046
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants