Skip to content

Nightly Dotty workflow of 2023-06-13 failed #17963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
github-actions bot opened this issue Jun 13, 2023 · 3 comments · Fixed by #17959
Closed

Nightly Dotty workflow of 2023-06-13 failed #17963

github-actions bot opened this issue Jun 13, 2023 · 3 comments · Fixed by #17959
Assignees
@Dedelweiss
Labels
itype:bug prio:blocker
Milestone
3.4.0

Comments

@github-actions
Copy link
Contributor

See https://github.com/lampepfl/dotty/actions/runs/5250777170
@ckipp01
Copy link
Member

ckipp01 commented Jun 13, 2023

This is a result of #17229. I've spoken to @Dedelweiss and he'll revert the change and then work on a fix. @Dedelweiss when you send in a PR to revert that you can tie is to this issue as well to close it.

@mbovel
Copy link
Member

mbovel commented Jun 13, 2023

Thanks @ckipp01! @Dedelweiss, please update us here as soon as this is done.

@Dedelweiss
Copy link
Contributor

Sure, a PR is underway and will be sent soon, sorry for the delay.

@Dedelweiss Dedelweiss mentioned this issue Jun 13, 2023
Merged
ckipp01 pushed a commit that referenced this issue Jun 13, 2023
@Dedelweiss
Fix: Error Sidebar PR failed test (#17959)
d83aa49 
The purpose of this Pull request is to correct my PR
#17229
Sorry for this failure.
I have tested the following command locally and my tests pass.
`sbt ";dist/pack ;scala3-bootstrapped/compile
;scala3-bootstrapped/test"`

[test_windows_full]

Fixes: #17963
@Kordyjan Kordyjan added this to the 3.4.0 milestone Aug 2, 2023
Kordyjan pushed a commit that referenced this issue Nov 17, 2023
@Dedelweiss @Kordyjan
Fix: Error Sidebar PR failed test (#17959)
c11b859 
The purpose of this Pull request is to correct my PR
#17229
Sorry for this failure.
I have tested the following command locally and my tests pass.
`sbt ";dist/pack ;scala3-bootstrapped/compile
;scala3-bootstrapped/test"`

[test_windows_full]

Fixes: #17963
[Cherry-picked d83aa49]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dedelweiss Dedelweiss

Labels
itype:bug prio:blocker
Projects
None yet
Milestone
3.4.0
Development

Successfully merging a pull request may close this issue.

Fix: Error Sidebar PR failed test Dedelweiss/dotty
4 participants
@mbovel @Kordyjan @ckipp01 @Dedelweiss