Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up on reclassified tests in #18899 #18904

Closed
odersky opened this issue Nov 12, 2023 · 2 comments
Closed

Follow up on reclassified tests in #18899 #18904

odersky opened this issue Nov 12, 2023 · 2 comments
Assignees
Labels
cc-experiment Intended to be merged with cc-experiment branch on origin

Comments

@odersky
Copy link
Contributor

odersky commented Nov 12, 2023

#18899 contains three test reclassifications:

  • i15922.scala was moved to pending. Not clear whether this should compile, and what changes would be necessary to get it there.
  • future-traverse.scala was moved to pending. Not clear how to make this compiler.
  • i15749a.scala was moved to neg. The issue description seems to indicate that the test should not compile, but I am not sure what the outcome should be.

We need to follow up on these and either classify them as definite errors / unimplementable or find alternative ways to make them compile.

@odersky odersky added the stat:needs triage Every issue needs to have an "area" and "itype" label label Nov 12, 2023
@odersky odersky added cc-experiment Intended to be merged with cc-experiment branch on origin and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Nov 12, 2023
@Linyxus
Copy link
Contributor

Linyxus commented Nov 16, 2023

I have reclassified these tests in this commit.

Summary:

  • For i15922, it should not work, as both bad1 and bad2 leak scoped
    capabilities. It is moved to neg tests.
  • For future-traverse.scala, we could make it work this way. Previously it won't
    compile because we instantiated the type parameter of successful with a
    universal capability, but actually we needn't do that: we could well pick a
    local reach capability, as is done in this commit.
  • For i15749a.scala, it should work but sadly not right now, due to a limitation
    of our current implementation.

@Linyxus Linyxus closed this as completed Nov 16, 2023
@Linyxus
Copy link
Contributor

Linyxus commented Nov 16, 2023

For the limitation mentioned in the previous comment is explained here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cc-experiment Intended to be merged with cc-experiment branch on origin
Projects
None yet
Development

No branches or pull requests

2 participants